Skip to content

Add trailing slash to namespace strings#238

Merged
jariy17 merged 1 commit intoaws:mainfrom
xinaizha:feature/namespace-trailing-slash
Feb 1, 2026
Merged

Add trailing slash to namespace strings#238
jariy17 merged 1 commit intoaws:mainfrom
xinaizha:feature/namespace-trailing-slash

Conversation

@xinaizha
Copy link
Contributor

Issue #, if available:

Description of changes:
Add trailing slash to namespace strings

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@xinaizha xinaizha requested a review from a team January 30, 2026 14:21
Copy link
Contributor

@jariy17 jariy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you expand on this PR with more details:

  • What is the problem?
  • How should we fix it?
  • How can we verify the fix works?
    Once we have this information, we can review your PR

@xinaizha
Copy link
Contributor Author

  1. The problem: We are using namespace with trailing slash as the standard/default convention, so we want to ensure all memory namespace examples consistently use trailing slashes for proper path parsing and prefix matching.
  2. To fix it: end each namespace with a trailing slash.
  3. Test: have done unit tests

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@a48944a). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage        ?   90.50%           
=======================================
  Files           ?       35           
  Lines           ?     3412           
  Branches        ?      507           
=======================================
  Hits            ?     3088           
  Misses          ?      179           
  Partials        ?      145           
Flag Coverage Δ
unittests 90.50% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jariy17 jariy17 merged commit 1de940d into aws:main Feb 1, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants