feat: add java8.al2023, java11.al2023, java17.al2023 runtime support - #556
Conversation
github-actions
Bot
added
pr/external
stage/needs-triage
Add init templates for Java AL2023 runtimes: - Copy template directories from base runtimes (java8.al2, java11, java17) - Update cookiecutter.json, template.yaml, and Dockerfiles with al2023 runtime/image refs - Add entries to manifest-v2.json for both Zip and Image package types - Add unit test files and CI workflow entries
747b546 to
03b250b
Compare
![aws-sam-tooling-bot[bot]](https://avatars.githubusercontent.com/b/1290?s=60&v=4){kind=small}
There was a problem hiding this comment.
Two minor gaps to consider:
-
Missing
hello-pt-gradlefor java8.al2023 -- java11.al2023 and java17.al2023 have bothhello-pt-gradleandhello-pt-maven(Powertools). java8.al2023 only hashello-pt-maven. If this is intentional (Powertools Gradle doesn't target java8), a brief note in the PR description would help. -
Missing
__init__.pyfor java8.al2023 -- java11.al2023 and java17.al2023 have a top-level__init__.pyfor Python test discovery. java8.al2023 does not -- this may cause test collection issues.
Otherwise LGTM. SAM Globals, Outputs, cookiecutter patterns all follow existing conventions.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Both are consistent with the base java8.al2, it doesn't have hello-pt-gradle or init.py either, so we kept the same template set for the al2023 copy. Good eye though, appreciate it! |
- Fix 8-space indent to 4-space in test_java_11_al2023.py - Add ': Maven' / ': Gradle' suffix to java11.al2023 Powertools displayNames to match java17.al2023 pattern
3 participants
Issue #, if available:
Description of changes:
Support for java8.al2023, java11.al2023, java17.al2023 Lambda managed runtimes according to the Lambda upcoming runtimes documentation.
Note: java8.al2023 does not include hello-pt-gradle or init.py , this is intentional, matching the base java8.al2 which also lacks both. The Powertools Gradle template was never created for java8.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.