Conversation
2 tasks
2 tasks
This was referenced Sep 9, 2026
Add --redirect-port to aws sso login and aws configure sso so users can select a fixed callback port and configure port forwarding in advance. Validate the port before prompting or starting authentication. Preserve random port selection when the option is omitted, and leave device code flows unchanged.
Extend --redirect-port to aws login so console-based login can use the same fixed-port forwarding setup as SSO login. Reuse the shared option and validation, passing the selected port to the same-device callback server. Leave the --remote flow unchanged.
ashovlin
marked this pull request as draft
September 21, 2026 21:21
ixxq
force-pushed
the
feat/sso-redirect-port
branch
from
September 23, 2026 23:10
b565da1 to
986ba2f
Compare
ixxq
changed the title
ixxq
marked this pull request as ready for review
September 23, 2026 23:20
Author
|
Hi @ashovlin, I've updated this PR as discussed in #10636:
I've marked it ready for review. Could you take a look when you have a chance? I also saw the callback binding and error-message comments on #10636. I've left those existing behaviors unchanged for now. Would you prefer to address those concerns in this PR or separately? Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #10433
Description of changes: Adds a
--redirect-portoption toaws sso login,aws configure sso, andaws loginso users can specify a fixed localhost port for the authorization code callback server and configure port forwarding in advance.When the option is omitted, the existing behavior is preserved and the callback server continues to bind to a randomly selected available port. Login flows that do not use a callback server are unchanged.
Invalid port values are rejected before starting the login flow. SSO session configuration support is not included in this PR.
Added unit and functional test coverage for the CLI option across all three commands, invalid port values, and binding the callback server to the requested port.
Validated with targeted pytest, ruff, and pre-commit checks on macOS.
This contribution was prepared with assistance from AI tools and reviewed by @ixxq.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.