fix: add mcp as explicit dependency in strands template#366
Merged
Conversation
The strands template's mcp_client/client.py imports directly from the mcp package, but mcp was not declared in pyproject.toml. It was only available as a transitive dependency through strands-agents, which is fragile coupling that may break on any strands-agents update.
tejaskash
had a problem deploying
to
e2e-testing
GitHub Actions
Failure
Contributor
Coverage Report
|
padmak30
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp_client/client.pyimports directly from themcppackage (from mcp.client.streamable_http import streamablehttp_client), butmcpwas not declared inpyproject.tomlstrands-agents, which is fragile coupling that may break on anystrands-agentsupdate"mcp >= 1.19.0"as an explicit dependency, matching the version floor used by thelangchain_langgraphtemplateTest plan
pip install --dry-runconfirms no dependency resolution conflicts betweenmcp >= 1.19.0andstrands-agents >= 1.13.0