fix: add package marker comment to __init__.py template files#363
Merged
fix: add package marker comment to __init__.py template files#363
Conversation
The 12 __init__.py files in src/assets/python/ were 0-1 bytes (empty or single newline), which made them fragile through the Handlebars rendering pipeline and npm tarball distribution. This caused "works in Docker, breaks locally" issues for editable installs, pytest, and mypy. Replace empty content with a `# Package marker` comment so the files survive template rendering and packaging reliably.
tejaskash
requested a deployment
to
e2e-testing
GitHub Actions
Waiting
Contributor
Coverage Report
|
Contributor
|
/strands review |
Contributor
Review Complete ✅I've reviewed the PR and can confirm that no files are missing. Verification SummaryFiles changed: 13 total
Framework BreakdownAll frameworks are correctly covered:
*Note: crewai framework does not have an Content VerificationAll The snapshot test file correctly reflects all 12 changes from empty content to Additional Checks Performed
Conclusion: The PR is complete and comprehensive. All necessary files are included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__init__.pytemplate files with# Package markercomment__init__.pyin generated projects ("works in Docker, breaks locally" for editable installs, pytest, mypy)Files changed
12
__init__.pyfiles across all framework templates (autogen,crewai,googleadk,langchain_langgraph,openaiagents,strands) inmodel/andmcp_client/directories, plusstrands/capabilities/memory/__init__.py.Test plan
npm run buildsucceedsnpm testpasses (14 pre-existing failures unrelated to this change)npm pack --dry-run | grep __init__shows all 12 files at 17Bmodel/__init__.pyandmcp_client/__init__.pywith# Package markercontent