Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Reviewed the Terraform backend preview end-to-end. Overall the design is careful about the tricky parts:
- Ownership is refused in both directions (
assertBackendOwnership), a target's account/region/provider binding can't be silently reused, and outputs are re-validated against the target account/region ARN parts. - Credentials aren't written into config, plan args, or the
deployment.jsonbinding; providers are additionally pinned withallowed_account_ids, giving defense in depth if the SDK/provider resolution paths diverge from STS. - The
applied/wasAppliedgate prevents a fresh checkout from re-creating resources when local state is empty but the binding says the target was previously applied. - The compiler validates unsupported project fields (arrays, objects,
authorizerType,instrumentation, non-Python runtimes) before any Terraform runs, and physical-name length is enforced up front.literal()correctly escapes both${and%{interpolation forms and there's a targeted test for it. - Artifact packaging is deterministic (fixed mtime, sorted entries, symlink rejection,
.env*exclusion, uv-lock required) and the SHA is used both as the S3 object key and assource_hash, so a description-only change reliably keeps the ZIP object stable (verified by the compiler test). - Backend selection wiring goes through a single
validateBackendCreateInputin the CLI handler, TUI screen, and manager, so the "unsupported template" error can't be bypassed. - Tests use real temp directories and inject at true I/O boundaries (
ProcessStreamer,resolveIdentity,checkTool) — no fs mocking, no SDK stubbing beyond what's necessary.
Nothing rose to the level of a blocking issue. Ship it.
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2346 +/- ##
=========================================
Coverage 97.26% 97.26%
=========================================
Files 610 610
Lines 40590 40590
=========================================
Hits 39480 39480
Misses 1110 1110 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a standalone Terraform HCL template in
examples/terraform/nativefor an AgentCore Runtime and short-term Memory using nativehashicorp/awsresources and direct AgentCore APIs. Customers package the included Python sample and deploy it with ordinaryterraform init,plan, andapply.The template includes versioned encrypted S3 artifact storage, public-access blocking, an IAM runtime role with scoped artifact/logging/Memory permissions, configurable inputs, and Runtime/Memory outputs. No CLI implementation or dependency changes are included.
Files and usage
main.tf: AgentCore Runtime and Memory resources.versions.tf,variables.tf,outputs.tf: providers, inputs, and outputs.storage.tf,iam.tf: artifact storage and runtime permissions.agent.py,build.py: dependency-free sample and ZIP packaging.terraform.tfvars.example,README.md: configuration and deployment/invocation instructions.AWSCC provisions normal AgentCore resources without creating a CloudFormation stack. IAM and S3 use the AWS provider in both alternatives. Runtime uses Python 3.12 CodeZip and public networking; Memory has no long-term strategies. Application-specific resources and model permissions can be added to the
.tffiles.Validation