feat(eval): support session trace filters and log group prefixes - #2345
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, well-scoped change: SDK bump to pick up sessionTraceIds, help-text update, and a test covering the raw pass-through path.
- Verified
SessionTraceIds/CloudWatchFilterConfig.sessionTraceIdsexist in@aws-sdk/client-bedrock-agentcore@3.1136.0, so the^3.1135.0bump is sufficient. - The test in
src/core/batchEvaluation.test.tsxmocks at the AWS SDK client boundary (send), which is the right layer — not over-mocked. - No new user-facing commands are introduced, so no additional telemetry instrumentation is warranted.
One minor thing to double-check (not a blocker): the help text in src/handlers/eval/sessionSource.tsx states traceIds accepts "up to 100 trace IDs". The SDK typings don't encode that limit; worth confirming against the public API docs before this misleads users if the real cap differs. Fine to address in a follow-up.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2345 +/- ##
=========================================
Coverage 97.26% 97.26%
=========================================
Files 610 610
Lines 40590 40605 +15
=========================================
+ Hits 39480 39495 +15
Misses 1110 1110 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d5ac908 to
576581f
Compare
|
Claude Security Review: no high-confidence findings. (run) |
Summary
CloudWatchFilterConfig.sessionTraceIdssessionTraceIdsandlogGroupNamePrefixesin the existing batch-evaluation--data-source-confighelpStartBatchEvaluationCommandunchangedlogGroupNamePrefixesas well as exact log group namesTesting
bun test src/handlers/eval/batch-evaluation/batch-evaluation.fixture.test.tsx src/handlers/eval/online-eval/online-eval.test.tsxbun test src/core/onlineEvalExecutionRole.test.ts src/handlers/eval/batch-evaluation/batch-evaluation.test.tsx src/handlers/eval/online-eval/online-eval.screen.test.tsxbun run typecheckbunx oxlint src/core/eval.tsx src/core/onlineEvalExecutionRole.tsx src/handlers/eval/sessionSource.tsx src/handlers/eval/batch-evaluation/batch-evaluation.fixture.test.tsx src/handlers/eval/online-eval/online-eval.test.tsxgit diff --check