[actionless]

currently the build throws a warning:

[ 85%] Linking C executable awesome
In function ‘memcpy’,
    inlined from ‘xutil_get_text_property_from_reply’ at /home/lie/.cache/pikaur/build/awesome-luajit-git/src/build/common/xutil.h:50:9,
    inlined from ‘client_manage’ at /home/lie/.cache/pikaur/build/awesome-luajit-git/src/build/objects/client.c:2410:24:
/usr/include/bits/string_fortified.h:29:10: warning: ‘__builtin_memcpy’ specified bound between 18446744071562067968 and 18446744073709551615 exceeds maximum object size 922337203
6854775807 [-Wstringop-overflow=]
   29 |   return __builtin___memcpy_chk (__dest, __src, __len,
      |          ^
[100%] Built target awesome

because since xcb_get_property_value_length() returns a signed int, it makes the range of return value which later passed to memcpy() as length potentially negative

and above would cause to overflow the length into aforementioned length in the warning message

[codecov]

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.43%. Comparing base (c463e19) to head (d060382).

Files with missing lines	Patch %	Lines
common/xutil.h	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4136      +/-   ##
==========================================
- Coverage   90.43%   90.43%   -0.01%     
==========================================
  Files         941      941              
  Lines       60363    60364       +1     
  Branches     1139     1140       +1     
==========================================
  Hits        54591    54591              
  Misses       5266     5266              
- Partials      506      507       +1     

Files with missing lines	Coverage Δ
common/xutil.h	87.50% <85.71%> (-5.84%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Aire-One]

I think it's a duplicate of #4087.

I don't get this warning when building Awesome, and the latest CI run on master also don't report it (https://github.com/awesomeWM/awesome/actions/runs/40995784216/job/123868463047).

I guess this is due to using another C compiler. @cnjhb mentioned they use clang.

I haven't had the time to complete my work yet, but I think we should have a way to build Awesome with clang in our CI, and/or run clang-tidy to lint the C code. This would automatically detect and force us to resolve all these issues.