Conversation
- Some results need to be public, so add public section (that seems innuous enough) - one proof by `rfl` is only so when definitions are exposed (otherwise, `(rfl)` would suffice) I'll assume you don't want to teach the difference here, so just expose the definitions and move on.
grunweg
commented
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Zulip discussion:
While MIL's files are independent (each file only imports a
Commonfile, and mathlib), so hiding definitions made in this project is less relevant, the module system offers one clear advantage: the memory footprint to import (parts of) mathlib is much lower. Hopefully, this will allow users with not as much RAM to use MIL for a little while longer.Most changes are very mechanical. A few files need
public sectionadded, as they make new definitions.One file should use @[expose] (as it uses a proof by
rfl, as explained in its commit message).A third file needs to
meta importtwo mathlib files to run#eval.