IMX I2C driver#662
Open
omeh-a wants to merge 12 commits into
Open
Conversation
omeh-a
marked this pull request as draft
March 6, 2026 04:19
midnightveil
reviewed
Mar 6, 2026
| ${CC} ${CFLAGS} -c -o $@ $< | ||
|
|
||
| i2c/i2c_common.o: CFLAGS+=-I${I2C_DRIVER_DIR} | ||
| i2c/i2c_common.o: ${I2C_DRIVER_DIR}/../i2c_common.c |i2c $(SDDF_LIBC_INCLUDE) |
Contributor
There was a problem hiding this comment.
this seems a bit weird with the relative paths
Member
Author
There was a problem hiding this comment.
The other i2c drivers are identical, so I will leave this as is. If we want to change it, worth an issue to do this to all of them.
This was referenced Mar 12, 2026
Draft
Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au> Timer tests out with acacia Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au> Serial tests out with Acacia Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au> Refactor: acacia_sddf is now a python module that inherits all subfiles, sDDF itself is a python module for import! Needed for SDK Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au> Fix issues with i2c.py - maps were swapped. Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au> Further fixes to keep up with Acacia PR request changes Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au>
Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au>
omeh-a
force-pushed
the
i2c_imx_driver
branch
4 times, most recently
from
July 3, 2026 00:09
6f4207a to
51905a9
Compare
omeh-a
marked this pull request as ready for review
July 3, 2026 00:10
Member
Author
|
This is now ready for review, albeit is unmergable until we have put Acacia into the tree under this. |
Member
Author
|
Completely unclear to me as to why the license check was failing on i2c_driver.mk before?? It has a comment. Just making a new commit to make it check again fixed it (alongside deleting the redundant, copyright-less config.json) |
Member
Author
|
CI tests currently borked due to not installing Acacia. I will add this in the sdfgenpy branch this branch is sitting on top of. But: there is a CI test that will work if you run it locally with Acacia installed. |
Member
Author
|
I need to fix coauthored-by for the initial driver commit |
Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au>
Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au>
Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au>
Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au>
Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au>
Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au>
Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au>
Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au>
Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au>
…o disabled in dtb Signed-off-by: Lesley Rossouw <lesley.rossouw@unsw.edu.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the I2C core of almost IMX8M boards. This was only tested on the IMX8MQ on the Maaxboard for now however, but theoretically this should work for all other IMX8MQ and IMX8Mmini boards.
On the Maaxboard, there is an odd quirk. Using any bus other than I2C1 (PMIC bus) causes the driver to silently hang. Consulting with @midnightveil and @Ivan-Velickovic leads me to believe that this is probably due to the other I2C buses being clock gated at boot.
This PR is a draft that we are rushing for a deliverable. We need to do the following things before merging: