fix: harden SSRF controls for RTMS/media fetches and enable RTMS TLS verify - #939
Open
valvesss wants to merge 1 commit into
Open
fix: harden SSRF controls for RTMS/media fetches and enable RTMS TLS verify#939valvesss wants to merge 1 commit into
valvesss wants to merge 1 commit into
Conversation
…verify Validate Zoom RTMS signaling/media URLs (host allowlist + public DNS) and HTTPS media downloads before the worker connects. Default RTMS WebSocket TLS to certificate verification (opt out via ZOOM_RTMS_SSL_INSECURE). Co-authored-by: Vitor Alves <vitoralvesinfo@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
valvesss
force-pushed
the
fix/security-ssrf-tls
branch
from
August 7, 2026 15:06
f1df49f to
8f7b662
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security hardening for server-side fetches that Attendee workers/bots perform on behalf of API clients.
server_urls/media_urlbefore connect (wss://, Zoom host allowlist, public DNS). API + adapter.ssl.create_default_context(); opt out withZOOM_RTMS_SSL_INSECURE=true.MP4Demuxer.REQUIRE_PUBLIC_WEBHOOK_URLSdefaultfalse(self-host); alreadyallow_redirects=False.Helpers in
bots/ssrf.py(re-exported bywebhook_utils.url_is_public).Env knobs
ZOOM_RTMS_HOST_SUFFIX_ALLOWLIST.zoom.us,.zoom.com,.zoomgov.comZOOM_RTMS_SSL_INSECURECERT_NONE.Test plan
Local (Mimir): Postgres 15.3 + Redis 7 + Django test settings.
bots.tests.test_ssrf+ related utils — 89/89 OKStill for CI/maintainer: full matrix in Docker image; live Zoom RTMS with TLS verify.
Contribution from Cold Code Labs · authored via Brokk · co-authors in commit trailers.