fix: ensure atkey namespace is marshalled by VerbBuilder with() methods #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akafredperry
requested review from
JeremyTubongbanua and
cpswan
and removed request for
JeremyTubongbanua
cpswan
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed the bugs in VerbBuilders.java. The with() method for the builders for update,delete,lookup,llookup and plookup was failing to marshall the atKey namespace
- How I did it
changed the builder methods to invoke getFullyQualifiedKeyName(). this appends the namespace to the key name.
- How to verify it
I created new unit tests for each of the builders.
- Description for the changelog
fix: ensure atkey namespace is correctly marshalled for update, delete, lookup, llookup and plookup