feat(nestjs-signed-url): add s3 signed url provider#402
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b166f2f81
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c54be9b1a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Task
How to verify
Main scenario
@atls/nestjs-signed-urlpackage validation for S3-compatible signed URLs.Action: Run
cd packages/nestjs-signed-url && yarn test unit --test-reporter=tapwith Node 22.22.3.Expected result: The package unit suite passes, including S3 gateway and module coverage.
Additional scenario
Action: Run
yarn checkwith Node 22.22.3.Expected result: The repository check completes successfully.
Proofs
mise x node@22.22.3 -- yarn installpassed.rg --files packages/nestjs-signed-url | xargs mise x node@22.22.3 -- yarn formatpassed.rg --files packages/nestjs-signed-url -g '*.ts' | xargs mise x node@22.22.3 -- yarn lintpassed.mise x node@22.22.3 -- yarn typecheck packages/nestjs-signed-urlpassed.cd packages/nestjs-signed-url && mise x node@22.22.3 -- yarn test unit --test-reporter=tappassed: 25 tests, 25 pass.cd packages/nestjs-signed-url && mise x node@22.22.3 -- yarn run buildpassed.mise x node@22.22.3 -- yarn explain peer-requirements p775256passed:reflect-metadata0.2.2satisfies all requests.mise x node@22.22.3 -- yarn checkpassed.git diff --checkpassed.