Skip to content

feat(nestjs-signed-url): add s3 signed url provider#402

Merged
TorinAsakura merged 3 commits into
masterfrom
feat/signed-url-s3-provider
Jun 24, 2026
Merged

feat(nestjs-signed-url): add s3 signed url provider#402
TorinAsakura merged 3 commits into
masterfrom
feat/signed-url-s3-provider

Conversation

@TorinAsakura

@TorinAsakura TorinAsakura commented Jun 24, 2026

Copy link
Copy Markdown
Member

Task

How to verify

Main scenario

  1. Context: @atls/nestjs-signed-url package validation for S3-compatible signed URLs.
    Action: Run cd packages/nestjs-signed-url && yarn test unit --test-reporter=tap with Node 22.22.3.
    Expected result: The package unit suite passes, including S3 gateway and module coverage.

Additional scenario

  1. Context: repository validation after adding the S3 signing provider.
    Action: Run yarn check with Node 22.22.3.
    Expected result: The repository check completes successfully.

Proofs

  • mise x node@22.22.3 -- yarn install passed.
  • rg --files packages/nestjs-signed-url | xargs mise x node@22.22.3 -- yarn format passed.
  • rg --files packages/nestjs-signed-url -g '*.ts' | xargs mise x node@22.22.3 -- yarn lint passed.
  • mise x node@22.22.3 -- yarn typecheck packages/nestjs-signed-url passed.
  • cd packages/nestjs-signed-url && mise x node@22.22.3 -- yarn test unit --test-reporter=tap passed: 25 tests, 25 pass.
  • cd packages/nestjs-signed-url && mise x node@22.22.3 -- yarn run build passed.
  • mise x node@22.22.3 -- yarn explain peer-requirements p775256 passed: reflect-metadata 0.2.2 satisfies all requests.
  • mise x node@22.22.3 -- yarn check passed.
  • git diff --check passed.

@TorinAsakura TorinAsakura self-assigned this Jun 24, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b166f2f81

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/nestjs-signed-url/src/s3/gateway.ts Outdated
Comment thread packages/nestjs-signed-url/src/s3/gateway.ts
Comment thread packages/nestjs-signed-url/package.json

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c54be9b1a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/nestjs-signed-url/src/s3/gateway.ts
@TorinAsakura TorinAsakura merged commit 3b4b48d into master Jun 24, 2026
6 checks passed
@TorinAsakura TorinAsakura deleted the feat/signed-url-s3-provider branch June 24, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add S3 and R2 signed URL provider

1 participant