feat(nestjs-signed-url): wire gcs client boundary#400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
How to verify
Main scenario
@atls/nestjs-signed-urlGCS module wiring through@atls/nestjs-gcs-clientAction: import
GcsClientModule.register()and injectGcsClientFactoryintoSignedUrlModule.gcsAsync(...).Expected result:
GcsSignedUrlSigneruses theStoragereturned by the public GCS client factory and maps write URL options to GCSGetSignedUrlConfig.Additional scenario
Action: typecheck and build
@atls/nestjs-signed-urland@atls/nestjs-gcs-clientunder Node 22.Expected result: both packages compile against the same
@google-cloud/storageversion and the signed-url package does not duplicate GCS client configuration fields.Proofs
mise x node@22.22.3 -- yarn format packages/nestjs-gcs-client/package.json packages/nestjs-signed-url/package.json packages/nestjs-signed-url/gcs/tests/module.test.ts: passedmise x node@22.22.3 -- yarn lint packages/nestjs-signed-url/gcs/tests/module.test.ts: passedmise x node@22.22.3 -- yarn typecheck packages/nestjs-signed-url: passedmise x node@22.22.3 -- yarn typecheck packages/nestjs-gcs-client: passedmise x node@22.22.3 -- yarn test unit --test-reporter=tapfrompackages/nestjs-signed-url: 17 tests passedmise x node@22.22.3 -- yarn run buildfrompackages/nestjs-signed-url: passedmise x node@22.22.3 -- yarn run buildfrompackages/nestjs-gcs-client: passedmise x node@22.22.3 -- yarn check: passedgit diff --check: passed