Skip to content

feat(nestjs-signed-url): add module registration api#399

Merged
TorinAsakura merged 2 commits into
masterfrom
feat/signed-url-module-api
Jun 23, 2026
Merged

feat(nestjs-signed-url): add module registration api#399
TorinAsakura merged 2 commits into
masterfrom
feat/signed-url-module-api

Conversation

@TorinAsakura

@TorinAsakura TorinAsakura commented Jun 23, 2026

Copy link
Copy Markdown
Member

Task

How to verify

Main scenario

  1. Context: @atls/nestjs-signed-url module registration API
    Action: run yarn typecheck packages/nestjs-signed-url, then run yarn test unit --test-reporter=tap from packages/nestjs-signed-url
    Expected result: TypeScript passes; unit tests cover register with useValue, useExisting, useClass, and registerAsync with useFactory, useClass, useExisting

Additional scenario

  1. Context: package publication surface
    Action: run yarn run build and yarn npm publish --dry-run --json from packages/nestjs-signed-url
    Expected result: package builds to dist/index.js; dry-run archive contains production dist/**, CHANGELOG.md, and package.json, without module test files

Proofs

  • yarn format packages/nestjs-signed-url/src/module/interfaces.ts packages/nestjs-signed-url/src/module/module.ts packages/nestjs-signed-url/module/tests/module.test.ts packages/nestjs-signed-url/module/tests/fixtures/constants.ts packages/nestjs-signed-url/module/tests/fixtures/consumer.ts packages/nestjs-signed-url/module/tests/fixtures/gateway.ts packages/nestjs-signed-url/module/tests/fixtures/module.ts: passed
  • yarn lint packages/nestjs-signed-url/src/module/interfaces.ts packages/nestjs-signed-url/src/module/module.ts packages/nestjs-signed-url/module/tests/module.test.ts packages/nestjs-signed-url/module/tests/fixtures/constants.ts packages/nestjs-signed-url/module/tests/fixtures/consumer.ts packages/nestjs-signed-url/module/tests/fixtures/gateway.ts packages/nestjs-signed-url/module/tests/fixtures/module.ts: passed
  • yarn typecheck packages/nestjs-signed-url: passed
  • yarn test unit --test-reporter=tap from packages/nestjs-signed-url: 16 tests passed
  • yarn run build from packages/nestjs-signed-url: passed
  • yarn npm publish --dry-run --json from packages/nestjs-signed-url: dry-run passed
  • git diff --check: passed

@TorinAsakura TorinAsakura self-assigned this Jun 23, 2026
@TorinAsakura TorinAsakura merged commit 41f01e0 into master Jun 23, 2026
7 checks passed
@TorinAsakura TorinAsakura deleted the feat/signed-url-module-api branch June 23, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add register and registerAsync module APIs

1 participant