refactor(nestjs-signed-url): restructure signing boundaries#398
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c8ff56206
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 922f20a96d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f542cd0977
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Task
How to verify
Main scenario
@atls/nestjs-signed-urlGCS module wiringAction: Use
SignedUrlModule.gcs({ useValue: storage })and resolveSignedUrlSigner.Expected result: The signer delegates to
GcsSignedUrlGateway; the signed-url package does not construct the GCS SDK client.Additional scenario
Context:
@atls/nestjs-signed-urlGCS client DIAction: Use
SignedUrlModule.gcsAsync(...)with an imported factory provider and resolveSignedUrlSigner.Expected result: The signer uses the injected factory result as the GCS client.
Context:
@atls/nestjs-signed-urlGCS signing optionsAction: Generate a GCS read URL with provider-specific
gcsoptions such asvirtualHostedStyle,cname, andqueryParams.Expected result: The GCS gateway forwards those options into
GetSignedUrlConfigwithout adding provider bags to common signed-url options.Proofs
yarn check{"status":"passed","typecheckFiles":465,"lintFiles":463}yarn typecheck packages/nestjs-signed-url{"status":"passed","files":22}yarn test unit --test-reporter=tapfrompackages/nestjs-signed-url{"status":"passed","tests":10,"fail":0}yarn run buildfrompackages/nestjs-signed-url{"status":"passed","files":12}