Skip to content

refactor(nestjs-signed-url): restructure signing boundaries#398

Merged
TorinAsakura merged 17 commits into
masterfrom
refactor/signed-url-boundaries
Jun 23, 2026
Merged

refactor(nestjs-signed-url): restructure signing boundaries#398
TorinAsakura merged 17 commits into
masterfrom
refactor/signed-url-boundaries

Conversation

@TorinAsakura

@TorinAsakura TorinAsakura commented Jun 23, 2026

Copy link
Copy Markdown
Member

Task

How to verify

Main scenario

  1. Context: @atls/nestjs-signed-url GCS module wiring
    Action: Use SignedUrlModule.gcs({ useValue: storage }) and resolve SignedUrlSigner.
    Expected result: The signer delegates to GcsSignedUrlGateway; the signed-url package does not construct the GCS SDK client.

Additional scenario

  1. Context: @atls/nestjs-signed-url GCS client DI
    Action: Use SignedUrlModule.gcsAsync(...) with an imported factory provider and resolve SignedUrlSigner.
    Expected result: The signer uses the injected factory result as the GCS client.

  2. Context: @atls/nestjs-signed-url GCS signing options
    Action: Generate a GCS read URL with provider-specific gcs options such as virtualHostedStyle, cname, and queryParams.
    Expected result: The GCS gateway forwards those options into GetSignedUrlConfig without adding provider bags to common signed-url options.

Proofs

  • yarn check
{"status":"passed","typecheckFiles":465,"lintFiles":463}
  • yarn typecheck packages/nestjs-signed-url
{"status":"passed","files":22}
  • yarn test unit --test-reporter=tap from packages/nestjs-signed-url
{"status":"passed","tests":10,"fail":0}
  • yarn run build from packages/nestjs-signed-url
{"status":"passed","files":12}

@TorinAsakura TorinAsakura self-assigned this Jun 23, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c8ff56206

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/nestjs-signed-url/src/module.ts Outdated
Comment thread packages/nestjs-signed-url/src/gcs/gateway.ts
Comment thread packages/nestjs-signed-url/src/module.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 922f20a96d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/nestjs-signed-url/src/signer.ts Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@TorinAsakura

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 2e7117d65d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f542cd0977

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/nestjs-signed-url/src/module/module.ts Outdated
@TorinAsakura TorinAsakura merged commit d1d8873 into master Jun 23, 2026
6 checks passed
@TorinAsakura TorinAsakura deleted the refactor/signed-url-boundaries branch June 23, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Restructure signed URL package boundaries

1 participant