Skip to content

fix(design): add image start scripts#721

Merged
TorinAsakura merged 2 commits into
masterfrom
fix/design-image-start-script
Jun 23, 2026
Merged

fix(design): add image start scripts#721
TorinAsakura merged 2 commits into
masterfrom
fix/design-image-start-script

Conversation

@TorinAsakura

@TorinAsakura TorinAsakura commented Jun 23, 2026

Copy link
Copy Markdown
Member

Таска

Как проверять

До фикса

  1. Контекст: post-merge Release после апгрейда Raijin, image pack для design workspace.
    Действие: выполнить Release workflow для merge commit e5381780a21df77652776bf4404ac374c3b1e14b.
    Ожидаемый результат: job падает на @atls-ui-parts/design с Missing required package.json script "start-image" for launch command.

После фикса

  1. Контекст: приватные design image workspaces.
    Действие: проверить scripts в @atls-ui-admin/design, @atls-ui-parts/design и @atls-ui/design.
    Ожидаемый результат: каждый workspace содержит start-image: node dist/index.js и не содержит legacy start.

  2. Контекст: общий repo contract после апгрейда Raijin.
    Действие: выполнить yarn check.
    Ожидаемый результат: проверка проходит без ошибок.

Пруфы

  • Release failure: https://github.com/atls/hyperion/actions/runs/28058261115
  • node script map assertion — pass, start-image есть и legacy start отсутствует
  • yarn workspaces foreach -W --from '@atls-ui-admin/design' --from '@atls-ui-parts/design' --from '@atls-ui/design' exec node -e '...' — pass
  • yarn lint — pass
  • yarn check — pass до удаления legacy start; после удаления повторены script map assertion и git diff --check
  • git diff --check — pass

@TorinAsakura TorinAsakura self-assigned this Jun 23, 2026
@TorinAsakura TorinAsakura merged commit 426059d into master Jun 23, 2026
7 checks passed
@TorinAsakura TorinAsakura deleted the fix/design-image-start-script branch June 23, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dependencies] Обновить Hyperion до последнего Raijin

1 participant