fix(design): add image start scripts#721
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Таска
Как проверять
До фикса
Действие: выполнить Release workflow для merge commit
e5381780a21df77652776bf4404ac374c3b1e14b.Ожидаемый результат: job падает на
@atls-ui-parts/designсMissing required package.json script "start-image" for launch command.После фикса
Контекст: приватные design image workspaces.
Действие: проверить scripts в
@atls-ui-admin/design,@atls-ui-parts/designи@atls-ui/design.Ожидаемый результат: каждый workspace содержит
start-image: node dist/index.jsи не содержит legacystart.Контекст: общий repo contract после апгрейда Raijin.
Действие: выполнить
yarn check.Ожидаемый результат: проверка проходит без ошибок.
Пруфы
nodescript map assertion — pass,start-imageесть и legacystartотсутствуетyarn workspaces foreach -W --from '@atls-ui-admin/design' --from '@atls-ui-parts/design' --from '@atls-ui/design' exec node -e '...'— passyarn lint— passyarn check— pass до удаления legacystart; после удаления повторены script map assertion иgit diff --checkgit diff --check— pass