Skip to content

refactor(libcnb): clarify library boundaries#108

Merged
TorinAsakura merged 16 commits into
masterfrom
refactor/libcnb-boundaries
Jul 1, 2026
Merged

refactor(libcnb): clarify library boundaries#108
TorinAsakura merged 16 commits into
masterfrom
refactor/libcnb-boundaries

Conversation

@TorinAsakura

@TorinAsakura TorinAsakura commented Jun 30, 2026

Copy link
Copy Markdown
Member

Таска

Как проверять

Основной сценарий

  1. Контекст: пакет @atls/libcnb как библиотека для buildpack-пакетов.
    Действие: проверить, что buildpack.toml читается через слой конфигурации, detect и build запускаются через модули run внутри своих фаз, файлы build.toml и launch.toml живут в слое файлов жизненного цикла, а слои публикуют interfaces.ts рядом с владельцем.
    Ожидаемый результат: ответственность читается из пути и роли файла; descriptor, metadata как псевдослой, detect/detect, build/build и contract.interface отсутствуют.

Дополнительный сценарий

  1. Контекст: buildpack-потребители yarn-install, yarn-cache и yarn-workspace-start.
    Действие: проверить, что исходные файлы не повторяют имя пакета, тесты живут в отдельных tests-папках, а detect запускает собранный dist из подготовленного каталога пакета.
    Ожидаемый результат: точки входа пакетов продолжают собираться и запускаться после переименований; тесты не лежат рядом с рабочими файлами в src.

Пруфы

  • yarn lint
  • yarn typecheck
  • yarn test unit
  • yarn test integration
  • yarn workspace @atls/libcnb build
  • yarn workspace @atls/buildpack-yarn-install build
  • yarn workspace @atls/buildpack-yarn-cache build
  • yarn workspace @atls/buildpack-yarn-workspace-start build
  • git diff --check
  • проверка detect в подготовленном каталоге пакета: yarn-install вернул 100, yarn-cache вернул 100, yarn-workspace-start вернул 0

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a89657b815

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread libcnb/src/build/run.ts Outdated
Comment thread libcnb/src/detect/run.ts Outdated
Comment thread libcnb/src/detect/run.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85d3ee8eb4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread libcnb/src/build/run.ts Outdated
Comment thread libcnb/src/config/buildpack.ts
Comment thread libcnb/src/build/result.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce824e9470

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread libcnb/src/config/buildpack.ts Outdated
Comment thread libcnb/src/layers/interfaces.ts Outdated
Comment thread libcnb/src/lifecycle/launch.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11def24704

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread libcnb/src/lifecycle/launch.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 630f1a9d8f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread libcnb/src/detect/interfaces.ts
@TorinAsakura TorinAsakura merged commit 785f8dc into master Jul 1, 2026
6 checks passed
@TorinAsakura TorinAsakura deleted the refactor/libcnb-boundaries branch July 1, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Architecture] Refactor libcnb library boundaries and contracts

1 participant