Repository navigation
Detect invalid enum values in Paper configuration files - #224
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a setting in a Paper configuration file has a value that is not one of the allowed values, Paper logs this error, ignores the value and uses the default.
This was not detected before.
This PR adds
InvalidEnumValueProblemto thePaperAnalyser, becauseEnumValueSerializeris only used for the Paper configuration files.The log does not name the file or the setting, only the invalid value and the allowed values, so the message shows both.
The new
UseValidEnumValueSolutiontells the user to search the Paper configuration files for the invalid value and replace it.Paper lists at most ten allowed values and adds
, ...when there are more; the list is shown as Paper logs it.Changes
InvalidEnumValueProblemUseValidEnumValueSolutionpaper-invalid-enum-value-26-3.log