Repository navigation
Detect plugins accessing the server outside of the main thread - #223
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a plugin does something that is only allowed on the main thread, like loading a chunk or changing a block, from another thread, Paper logs this error and throws
IllegalStateException: Asynchronous <action>!.This was not detected before.
This PR adds
MainThreadCheckProblemto thePaperAnalyser, because the message with the thread name is only logged by Paper.The message names the thread and the action, and the solutions name the plugin:
Craft Scheduler Thread - <n> - <plugin>, so the plugin is known and getsPluginInstallDifferentVersionSolutionandPluginRemoveSolutionPluginWithClassInstallDifferentVersionSolutionandPluginWithClassRemoveSolutionThere is only one message for all cases, because the name of a scheduler thread already contains the plugin.
The exception
Asynchronous chunk load!that follows is intentionally not matched separately, because it is the same error.Folia logs the check in another format (
Thread failed main thread check: ..., context=thread=...), which is not covered, because there is no real log of it.Changes
MainThreadCheckProblempaper-main-thread-check-block-26-3.log,paper-main-thread-check-chunk-load-26-3.logandpaper-main-thread-check-own-thread-26-3.log