Repository navigation
Detect an unusable .paper cache folder - #221
Merged
Merged
Conversation
…alid # Conflicts: # lang/en.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paper keeps a cache folder
.paperin the server folder.When
.paperexists as a file, or the folder cannot be created, for example because of missing permissions, the server crashes during startup.This was not detected before.
This PR adds
CacheDirInvalidProblemto thePaperAnalyser, because the cache folder only exists on Paper.Both causes have the same message, and the variant only decides the solution:
.paperis a file, with the existingFileDeleteSolution.papercannot be created, with the existingPaperCheckPermissionsSolutionThe exception appears twice in the log, once as a cause in the stack trace and once further down, but it is reported as one problem with a counter.
Changes
CacheDirInvalidProblempaper-cache-dir-not-directory-26-3.logandpaper-cache-dir-create-failed-26-3.log