Repository navigation
Detect a blocked main thread from the watchdog - #220
Merged
Merged
Conversation
# Conflicts: # lang/en.json # src/Analyser/BukkitAnalyser.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the main thread of the server hangs, the watchdog logs a thread dump.
Paper logs an early warning every few seconds while the server is still waiting, and after
timeout-timeinspigot.ymlthe watchdog stops the server.This was not detected before.
This PR adds
WatchdogProblemto theBukkitAnalyser, because the watchdog is part of Spigot.The early warning and the stop have the same cause, so they are one problem without variants: a log with both shows one message with a counter instead of two messages with the same solution.
The new
WatchdogThreadDumpSolutiontells the user to look for the plugin in the thread dump of theServer thread.The thread dump names the class of the plugin, but it is intentionally not used for the class-based plugin solutions: every line of the dump is its own log entry with a prefix, so a pattern cannot reach it from the message.
Changes
WatchdogProblemWatchdogThreadDumpSolutionpaper-watchdog-not-responding-26-3.logandpaper-watchdog-stopped-26-3.log