Repository navigation
fix(ble): start the Windows BLE receiver once Bluetooth is turned on - #96
Merged
Merged
Conversation
Started with Bluetooth off, the receiver's GattServiceProvider::CreateAsync failed with RadioNotAvailable and the task ended, so the PC stayed undiscoverable to phones over BLE until the app was restarted. It now waits for the radio to be on, through the radio's StateChanged event, before creating the service. Linux already waited for the adapter to power on. bluetooth_on() is bluetooth_turned_on() that also resolves at once when the radio is already on, so a radio that comes on between the check and the subscription isn't missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started with Bluetooth off, the receiver's GattServiceProvider::CreateAsync failed with RadioNotAvailable and the task ended, so the PC stayed undiscoverable to phones over BLE until the app was restarted. It now waits for the radio to be on, through the radio's StateChanged event, before creating the service. Linux already waited for the adapter to power on.
bluetooth_on() is bluetooth_turned_on() that also resolves at once when the radio is already on, so a radio that comes on between the check and the subscription isn't missed.