Use mimalloc v3 - #21014
Use mimalloc v3#21014chirizxc wants to merge 1 commit into
Conversation
Updated mimalloc dependency version for Windows target.
| [target.'cfg(all(not(target_os = "windows"), not(target_os = "openbsd"), not(target_os = "freebsd"), any(target_arch = "x86_64", target_arch = "aarch64", target_arch = "powerpc64")))'.dependencies] | ||
| tikv-jemallocator = { version = "0.6.0" } |
There was a problem hiding this comment.
It might be worth make these as features to avoid such long conditions and their duplication in the file?
|
This makes sense given that we've now merged it in Ruff, but I'll let @zanieb merge since they looked at the issue last time. |
|
My prior research on this was not compelling and showed memory use regressions that were hard to offset with configuration; it's a bit messy, but see #19743 |
On my machine, memory usage for ruff actually decreased (i used this script: astral-sh/ruff#27586 (comment)) |
|
Ruff is really different than uv, we'd need benchmarks for this project. |
|
I can still reproduce the cold resolve memory regressions:
|
Could you share your script? I'll run it locally on my computer. |
|
Sure, it's just generated by Codex https://github.com/astral-sh/uv/blob/zb/pr-21014-mimalloc-namespace-bench-20260811/.github/scripts/mimalloc-high-confidence-rss.ps1 |
Yeah, I think I was able to reproduce it locally |
As I understand it, you're running this benchmark on GitHub Windows Runner? upd. If it's not too much trouble, just for the sake of the test, could you also add https://github.com/moggedhedien/rimalloc to this bench? |
|
I was running it on a Namespace VM |
|
rimalloc doesn't have Windows support, it seems |
|
I've also tested several Rust projects using snmalloc, but it was usually slower |
Same as astral-sh/ruff#27586
Close #19189