Skip to content

[ty] Cover match subjects that refer to later captures - #28992

Closed
charliermarsh wants to merge 1 commit into
mainfrom
charlie/fix-ty-4610
Closed

charliermarsh wants to merge 1 commit into
mainfrom
charlie/fix-ty-4610

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Summary

Add regression coverage for a match subject that depends on a capture from a later case inside a loop. We report the unresolved attribute without panicking. This behavior was fixed by #28960, which changed how pattern-narrowing queries are cached.

Regression test for astral-sh/ty#4610.

@charliermarsh charliermarsh added the ty Multi-file analysis & type inference label Sep 29, 2026
@astral-sh-bot

astral-sh-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 98.24%. The percentage of expected errors that received a diagnostic held steady at 98.24%. The number of fully passing files held steady at 134/146.

@astral-sh-bot

astral-sh-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Full report with detailed diff (timing results)

@charliermarsh
charliermarsh marked this pull request as ready for review September 29, 2026 12:17
@charliermarsh
charliermarsh requested a review from a team as a code owner September 29, 2026 12:17
@charliermarsh charliermarsh added the bug Something isn't working label Sep 29, 2026
@astral-sh-bot
astral-sh-bot Bot requested a review from dhruvmanila September 29, 2026 12:17
@charliermarsh charliermarsh added testing Related to testing Ruff itself and removed bug Something isn't working labels Oct 2, 2026
@charliermarsh charliermarsh changed the title [ty] Stabilize cycle recovery for match pattern narrowing [ty] Cover match subjects that refer to later captures Oct 2, 2026

This branch was successfully deployed

1 active deployment
automations — 773dd83a Deployed Oct 2, 2026 by charliermarsh via security-review / security review #90574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Related to testing Ruff itself ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant