Repository navigation
Fix the external cmdstanpy tests on cmdstanpy 2 - #241
Open
jordandeklerk wants to merge 2 commits into
Open
jordandeklerk wants to merge 2 commits into
jordandeklerk wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
===========================================
- Coverage 73.76% 51.73% -22.04%
===========================================
Files 20 20
Lines 2051 2051
===========================================
- Hits 1513 1061 -452
- Misses 538 990 +452 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Documentation build overview
2 files changed± api/generated/arviz_base.dict_to_dataset.html± api/generated/arviz_base.extract.html |
Member
Author
|
@aloctavodia Maybe this a bit premature? Should we just wait until the official release of cmdstanpy 2? I believe it is in pre-release atm. |
Contributor
|
They have announced an RC |
jordandeklerk
marked this pull request as ready for review
November 20, 2026 12:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Special_versionsAzure job has been red on every PR for a while. It runs against cmdstanpydevelop, which is now 2.0, and our tests were building the fit from private internals that 2.0 got rid of.from_cmdstanpyworks fine with cmdstanpy 2, so this is tests only. The fixture now usesfrom_output_files(orfrom_csvon 1.x), and I regenerated the saved data since cmdstanpy 2 needs a config JSON next to each CSV.