Skip to content

Fix the external cmdstanpy tests on cmdstanpy 2 - #241

Open
jordandeklerk wants to merge 2 commits into
mainfrom
cmdstanpy
Open

jordandeklerk wants to merge 2 commits into
mainfrom
cmdstanpy

Conversation

@jordandeklerk

Copy link
Copy Markdown
Member

The Special_versions Azure job has been red on every PR for a while. It runs against cmdstanpy develop, which is now 2.0, and our tests were building the fit from private internals that 2.0 got rid of.

from_cmdstanpy works fine with cmdstanpy 2, so this is tests only. The fixture now uses from_output_files (or from_csv on 1.x), and I regenerated the saved data since cmdstanpy 2 needs a config JSON next to each CSV.

@codecov-commenter

codecov-commenter commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.73%. Comparing base (4ec2a2e) to head (954c391).

❗ There is a different number of reports uploaded between BASE (4ec2a2e) and HEAD (954c391). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4ec2a2e) HEAD (954c391)
4 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #241       +/-   ##
===========================================
- Coverage   73.76%   51.73%   -22.04%     
===========================================
  Files          20       20               
  Lines        2051     2051               
===========================================
- Hits         1513     1061      -452     
- Misses        538      990      +452     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@read-the-docs-community

read-the-docs-community Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 arviz-base | 🛠️ Build #36001417 | 📁 Comparing 954c391 against latest (4ec2a2e)

  🔍 Preview build  

2 files changed
± api/generated/arviz_base.dict_to_dataset.html
± api/generated/arviz_base.extract.html

@jordandeklerk

Copy link
Copy Markdown
Member Author

@aloctavodia Maybe this a bit premature? Should we just wait until the official release of cmdstanpy 2? I believe it is in pre-release atm.

@aloctavodia

Copy link
Copy Markdown
Contributor

They have announced an RC

@jordandeklerk
jordandeklerk marked this pull request as ready for review November 20, 2026 12:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants