hls: check ngx_array_push() result in postconfiguration#1804
Open
DmitryTD wants to merge 1 commit into
Open
Conversation
The audio/video event handler slots were dereferenced without checking the ngx_array_push() result for NULL, unlike the rest of nginx. Return NGX_ERROR on failure. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Mihalchenko <tascad@altlinux.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ngx_rtmp_hls_postconfiguration()registers event handlers viangx_array_push()and dereferences the result without checking for NULL.ngx_array_push()can return NULL on allocation failure, which would lead to a NULL pointer dereference.Add the missing NULL checks, returning
NGX_ERRORon allocation failure.