Skip to content

deps: update playwright to fix CI#833

Merged
phil-arcjet merged 3 commits into
mainfrom
phil-arcjet/update-playwright
Jun 12, 2026
Merged

deps: update playwright to fix CI#833
phil-arcjet merged 3 commits into
mainfrom
phil-arcjet/update-playwright

Conversation

@phil-arcjet

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
arcjet-docs Ready Ready Preview, Comment Jun 12, 2026 7:05pm

Request Review

@phil-arcjet phil-arcjet changed the title Phil arcjet/update playwright deps: update playwright to fix CI Jun 12, 2026
@socket-security

socket-security Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedplaywright@​1.58.2 ⏵ 1.60.0100 +11001009980 -19
Updated@​playwright/​test@​1.58.2 ⏵ 1.60.010010010099100

View full report

@arcjet-review arcjet-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arcjet Review — 🟡 Medium Risk

Decision: Reviewers Assigned

Rationale: This PR updates Playwright dev dependencies and changes analytics consent behavior for PostHog. The dependency change fires the dependency escalation trigger, and the versions were changed from exact pins to caret ranges without a corresponding lockfile update in the diff. The PostHog change appears intended to improve consent handling by defaulting capture off and opting in only after HubSpot analytics consent, but it should be manually verified against the HubSpot callback contract and PostHog initialization behavior. No specific reviewers are configured.

Summary of Changes

Updates @playwright/test and playwright from 1.58.2 to ^1.60.0, and gates PostHog capture behind the HubSpot privacy consent listener by defaulting PostHog capture to opt-out until analytics consent is present.

Escalation Triggers

  • Dependency Changes: package.json modifies devDependency versions for @playwright/test and playwright.

Security Flags

  • [LOW] Supply Chain (package.json:80): Playwright dependencies were changed from exact versions to caret ranges, which can allow future unreviewed minor/patch updates if the lockfile is regenerated or absent. Playwright packages also include install/browser tooling, so reproducible pinning is preferable.

Review Focus Areas

Notes

Automated review did not identify hardcoded secrets or injection risks in the shown diff. Manual review should focus on dependency reproducibility and privacy/consent behavior.

Path filtering: 1 file excluded by ignore paths. 2 of 3 files included in review.

Review: 0be0a05f | Model: openai/gpt-5.5 | Powered by Arcjet Review

@phil-arcjet phil-arcjet force-pushed the phil-arcjet/update-playwright branch from 1b6d8e2 to 4d9aa6b Compare June 12, 2026 18:26
@phil-arcjet phil-arcjet added the ai-review Trigger an AI review. label Jun 12, 2026
@arcjet-review arcjet-review Bot added ai-review-in-progress and removed ai-review Trigger an AI review. labels Jun 12, 2026

@arcjet-review arcjet-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arcjet Review — 🟢 Low Risk

Decision: Approved

Rationale: Scope has narrowed since the previous review — the PostHog analytics consent change is no longer part of this diff, leaving only a Playwright dev dependency bump from 1.58.2 to ^1.60.0 to fix CI. Playwright is a dev-only test dependency, the change is well-scoped, and the repo presumably has a lockfile that pins the exact resolved version. The remaining concern (caret vs. exact pin) is minor and stylistic; downgrading severity and approving with an inline note.

Summary of Changes

Bumps @playwright/test and playwright dev dependencies from 1.58.2 to ^1.60.0 to fix CI. Dev-only dependency update.

Escalation Triggers

  • Dependency Changes: package.json modified to bump Playwright versions

Notes

Previous review's PostHog/analytics consent concern is no longer present in the diff — scope is now limited to the Playwright bump. Assumes pnpm-lock/package-lock is updated in the PR (not shown via path filtering).

Path filtering: 1 file excluded by ignore paths. 1 of 2 files included in review.

Review: 8117c892 | Model: anthropic/claude-opus-4-7 | Powered by Arcjet Review

Comment thread package.json
Comment thread package.json

@qw-in qw-in left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would expect you'll need to regenerate some of the screenshots either locally or via the action to get it passing

Comment thread package.json
Comment thread src/lib/posthog.client.ts Outdated

@qw-in qw-in left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing this!

Comment thread package.json
@phil-arcjet phil-arcjet added this pull request to the merge queue Jun 12, 2026
Merged via the queue into main with commit d4b4c63 Jun 12, 2026
11 checks passed
@phil-arcjet phil-arcjet deleted the phil-arcjet/update-playwright branch June 12, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants