Add an option to allow following the symlinks#810
Open
epeicher wants to merge 2 commits intoarchiverjs:masterfrom
Open
Add an option to allow following the symlinks#810epeicher wants to merge 2 commits intoarchiverjs:masterfrom
epeicher wants to merge 2 commits intoarchiverjs:masterfrom
Conversation
|
@ctalkington, do you think we could consider exposing this |
This was referenced May 28, 2025
sejas
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will expose an
optionwhen creating anArchiverobject to allow following the symlinks, so instead of archiving the symlinks, the target folders and files of the symlinks will be archived.The usage will be something like:
Proposed changes
optionto theCoreOptionsobject namedfollowSymlinksfollowoption of thereaddirGlobfunction, so the symlinks are followed.Testing instructions
node-archiverrepo was cloned, e.g. /test-archiver`cdinto that foldernpm init -ynpm i ../node-archiver/tmp/test-foldertest-archiverfolderindex.js:node index.jsexample.zipfile has been created in that folder