Open
Conversation
belyshevdenis
requested changes
Sep 9, 2025
include/kf/stl/string
Outdated
| using u32string = kf::basic_string<char32_t, PoolType>; | ||
|
|
||
| // | ||
| // string to numeric |
Collaborator
There was a problem hiding this comment.
Цю функцію необхідно декомпозувати, частини можна помістити у сабнеймспейс detail
idx, на мою думку - це оверінженірінг, тому що стандартні функції такого не мають
Collaborator
Author
There was a problem hiding this comment.
stoi має параметри ( const std::string& str, std::size_t* pos = nullptr, int base = 10 ), де pos - an address of the first unconverted character in str.
Collaborator
There was a problem hiding this comment.
Зрозумів, лишай сигнатуру, але декомпозувати її необхідно
include/kf/stl/string
Outdated
| // numeric to string | ||
| // | ||
|
|
||
| constexpr size_t kMaxLongLongStrLength = 21; |
belyshevdenis
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: https://jira.dev.local/jira/browse/KF-44
Based on #81