Skip to content

fix: shorter clean branch name #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jirimoravcik merged 1 commit into from
Oct 6, 2026
Merged

fix: shorter clean branch name #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/get_values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ on:
description: Branch name stripped of non-alphanumeric characters, lowercased, and capped at length of 35
value: ${{ jobs.get_values.outputs.clean_branch_name }}
clean_branch_name_with_suffix:
description: Branch name stripped of non-alphanumeric characters, lowercased, and capped at length of 28 concatenated with the first 6 hex chars of its SHA-1
description: Branch name stripped of non-alphanumeric characters, lowercased, and capped at length of 24 concatenated with the first 6 hex chars of its SHA-1
value: ${{ jobs.get_values.outputs.clean_branch_name_with_suffix }}
commit_author:
description: Author of last commit
Expand Down Expand Up @@ -56,7 +56,8 @@ jobs:
_BRANCH_NAME=${BRANCH_NAME//[^[:alnum:]]/}
_BRANCH_NAME=$(echo "${_BRANCH_NAME}" | tr '[:upper:]' '[:lower:]')
CLEAN_BRANCH_NAME=$(echo ${_BRANCH_NAME} | cut -c 1-35)
CLEAN_BRANCH_NAME_WITH_SUFFIX=$(echo ${_BRANCH_NAME} | cut -c 1-28)-$(echo ${_BRANCH_NAME} | shasum -a 1 | cut -c 1-6)
# Used as a name prefix for Helm releases, whose names are capped at 53 chars, so keep it short.
CLEAN_BRANCH_NAME_WITH_SUFFIX=$(echo ${_BRANCH_NAME} | cut -c 1-24)-$(echo ${_BRANCH_NAME} | shasum -a 1 | cut -c 1-6)

echo "SHORT_COMMIT_SHA=${COMMIT_SHA::10}" >> $GITHUB_ENV
echo "short_commit_sha=${COMMIT_SHA::10}" >> $GITHUB_OUTPUT
Expand All @@ -78,4 +79,4 @@ jobs:
ref: commitSha,
});

return payload.data.commit.author.name;
return payload.data.commit.author.name;
Loading