Repository navigation
Conversation
The org-wide secrets are going away, so every job that reads one now declares the repository environment that holds it, synced from the `github-crawlee-python` Doppler project: - `automation` (`APIFY_SERVICE_ACCOUNT_GITHUB_TOKEN`): the changelog bump of the beta and stable releases, the versioned docs commit, the CloudFront invalidation and the Playwright and public suffix list updaters. - `docs` (`APIFY_SIGNING_TOKEN`, `SEGMENT_TOKEN`): the docs build. - `e2e-tests` (`APIFY_TEST_USER_API_TOKEN`, `OPENAI_API_KEY`, `SLACK_WEBHOOK_URL`): the scheduled e2e tests and their Slack alert. The changelog bump uses the `apify/actions/python-bump-and-update-changelog` action instead of the reusable workflow, since a job calling a reusable workflow cannot declare an environment. The CloudFront invalidation moves out of `deploy_docs` into its own job, so `github-pages` holds no secrets. The factory review uses the `apify/actions/factory-review` action instead of the reusable workflow, as in apify/crawlee#4438. Its secrets stay org-level. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ocuAGyh1Z8vh1T4sVRcha
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2489 +/- ##
==========================================
+ Coverage 94.25% 94.28% +0.02%
==========================================
Files 184 184
Lines 13711 13711
==========================================
+ Hits 12923 12927 +4
+ Misses 788 784 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The `automation`, `docs` and `e2e-tests` environments only hold secrets, so the jobs using them set `deployment: false` and don't record a deployment per job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ocuAGyh1Z8vh1T4sVRcha
Pull request runs use `e2e-tests-pr`, which requires an approval, and the scheduled and manual runs on master use `e2e-tests`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ocuAGyh1Z8vh1T4sVRcha
mtrunkat
approved these changes
Nov 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The org-wide secrets are going away, so every job that reads one now declares the repository environment that holds it, synced from the
github-crawlee-pythonDoppler project:automationAPIFY_SERVICE_ACCOUNT_GITHUB_TOKENdocsAPIFY_SIGNING_TOKEN,SEGMENT_TOKENe2e-testsAPIFY_TEST_USER_API_TOKEN,OPENAI_API_KEY,SLACK_WEBHOOK_URLapify/actions/python-bump-and-update-changelogaction instead of the reusable workflow, since a job that calls a reusable workflow cannot declare an environment.deploy_docsinto its own job, sogithub-pagesholds no secrets.apify/actions/factory-reviewaction instead of the reusable workflow, as in ci: read the service account token from repository environments crawlee#4438. Its secrets stay org-level, so it has no environment.Not changed yet:
CODECOV_TOKENandAPIFY_HTTPBIN_TOKENare read by the PR checks, which can't use environments restricted to protected branches. Whether they stay repo-level secrets is still open.on_schedule_tests.yamlalso runs on pull requests that touch the templates or e2e tests. Withenvironment: e2e-tests, those PR runs are refused unless the environment allows the PR branch. How PR runs should behave is still open.Issues
Testing
Checklist
Generated by Claude Code