Skip to content

docs: Set the cookie domain in the login guide example - #2488

Merged
vdusek merged 2 commits into
masterfrom
docs/login-cookie-domain
Nov 20, 2026
Merged

vdusek merged 2 commits into
masterfrom
docs/login-cookie-domain

Conversation

@vdusek

@vdusek vdusek commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

The login guide example set the token, userID, and userName cookies without a domain. A cookie without a domain is sent to every host the session visits, as the Cookie management page says. The example now passes domain='demoqa.com' for all three cookies, so they go only to the site the crawler logged in to.

The same change is ported to the 1.11 docs snapshot.

✍️ Drafted by Claude Code

@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Nov 20, 2026
@vdusek vdusek self-assigned this Nov 20, 2026
@vdusek
vdusek marked this pull request as ready for review November 20, 2026 08:10
@vdusek
vdusek requested a review from B4nan November 20, 2026 08:10
@B4nan

B4nan commented Nov 20, 2026

Copy link
Copy Markdown
Member

Let's port the change to the latest docs snapshot

@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.27%. Comparing base (b257d46) to head (1c8d520).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2488      +/-   ##
==========================================
+ Coverage   94.25%   94.27%   +0.02%     
==========================================
  Files         184      184              
  Lines       13711    13711              
==========================================
+ Hits        12923    12926       +3     
+ Misses        788      785       -3     
Flag Coverage Δ
integration 76.61% <ø> (+0.01%) ⬆️
unit 85.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek merged commit 7bd32e7 into master Nov 20, 2026
50 checks passed
@vdusek
vdusek deleted the docs/login-cookie-domain branch November 20, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants