Repository navigation
docs: Set the cookie domain in the login guide example - #2488
Merged
Merged
Conversation
vdusek
marked this pull request as ready for review
November 20, 2026 08:10
Member
|
Let's port the change to the latest docs snapshot |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2488 +/- ##
==========================================
+ Coverage 94.25% 94.27% +0.02%
==========================================
Files 184 184
Lines 13711 13711
==========================================
+ Hits 12923 12926 +3
+ Misses 788 785 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
B4nan
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The login guide example set the
token,userID, anduserNamecookies without a domain. A cookie without a domain is sent to every host the session visits, as the Cookie management page says. The example now passesdomain='demoqa.com'for all three cookies, so they go only to the site the crawler logged in to.The same change is ported to the 1.11 docs snapshot.
✍️ Drafted by Claude Code