Skip to content

Comments

TEZ-4672: Spotless: cleanup and force removing trailing whitespaces#450

Open
abstractdog wants to merge 1 commit intoapache:masterfrom
abstractdog:TEZ-4672
Open

TEZ-4672: Spotless: cleanup and force removing trailing whitespaces#450
abstractdog wants to merge 1 commit intoapache:masterfrom
abstractdog:TEZ-4672

Conversation

@abstractdog
Copy link
Contributor

No description provided.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 14s #450 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/1/console
versions git=2.34.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@Aggarwal-Raghav
Copy link
Contributor

Changes LGTM +1, pending yetus checks

Ran the mvn spotless:apply after taking just the pom changes and the diff b/w commits are same

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 15s #450 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/2/console
versions git=2.34.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Contributor Author

abstractdog commented Jan 26, 2026

fails due to Yetus limitations, now I'm retrying with @ayushtkn's wonderful workaround #423 (comment)

https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/3/

also, @ayushtkn if you have the chance to take a look at this change, I would appreciate, big thing, easy rules

              <trimTrailingWhitespace/>

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 5m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 3s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 91 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 2m 16s Maven dependency ordering for branch
+1 💚 mvninstall 7m 19s master passed
+1 💚 compile 6m 14s master passed
+1 💚 checkstyle 4m 35s master passed
+1 💚 javadoc 4m 55s master passed
-1 ❌ spotbugs 1m 1s /branch-spotbugs-tez-api.txt tez-api in master failed.
-1 ❌ spotbugs 0m 20s /branch-spotbugs-tez-common.txt tez-common in master failed.
-1 ❌ spotbugs 0m 20s /branch-spotbugs-tez-runtime-internals.txt tez-runtime-internals in master failed.
-1 ❌ spotbugs 0m 21s /branch-spotbugs-tez-runtime-library.txt tez-runtime-library in master failed.
-1 ❌ spotbugs 0m 19s /branch-spotbugs-tez-mapreduce.txt tez-mapreduce in master failed.
-1 ❌ spotbugs 0m 18s /branch-spotbugs-tez-examples.txt tez-examples in master failed.
-1 ❌ spotbugs 0m 26s /branch-spotbugs-tez-dag.txt tez-dag in master failed.
-1 ❌ spotbugs 0m 20s /branch-spotbugs-tez-tests.txt tez-tests in master failed.
-1 ❌ spotbugs 0m 20s /branch-spotbugs-tez-ext-service-tests.txt tez-ext-service-tests in master failed.
-1 ❌ spotbugs 0m 23s /branch-spotbugs-tez-plugins_tez-yarn-timeline-history.txt tez-yarn-timeline-history in master failed.
-1 ❌ spotbugs 0m 21s /branch-spotbugs-tez-plugins_tez-yarn-timeline-history-with-acls.txt tez-yarn-timeline-history-with-acls in master failed.
-1 ❌ spotbugs 0m 19s /branch-spotbugs-tez-plugins_tez-history-parser.txt tez-history-parser in master failed.
-1 ❌ spotbugs 0m 20s /branch-spotbugs-tez-plugins_tez-aux-services.txt tez-aux-services in master failed.
-1 ❌ spotbugs 0m 12s /branch-spotbugs-root.txt root in master failed.
-1 ❌ spotbugs 0m 20s /branch-spotbugs-tez-tools_analyzers_job-analyzer.txt job-analyzer in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 8s Maven dependency ordering for patch
+1 💚 mvninstall 6m 31s the patch passed
+1 💚 codespell 0m 54s No new issues.
+1 💚 compile 5m 37s the patch passed
+1 💚 javac 5m 37s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 15s /results-checkstyle-tez-api.txt tez-api: The patch generated 1 new + 553 unchanged - 1 fixed = 554 total (was 554)
-0 ⚠️ checkstyle 0m 10s /results-checkstyle-tez-common.txt tez-common: The patch generated 2 new + 66 unchanged - 2 fixed = 68 total (was 68)
-0 ⚠️ checkstyle 0m 15s /results-checkstyle-tez-runtime-library.txt tez-runtime-library: The patch generated 4 new + 689 unchanged - 4 fixed = 693 total (was 693)
-0 ⚠️ checkstyle 0m 13s /results-checkstyle-tez-mapreduce.txt tez-mapreduce: The patch generated 62 new + 690 unchanged - 62 fixed = 752 total (was 752)
-0 ⚠️ checkstyle 0m 20s /results-checkstyle-tez-dag.txt tez-dag: The patch generated 16 new + 1830 unchanged - 16 fixed = 1846 total (was 1846)
-0 ⚠️ checkstyle 0m 14s /results-checkstyle-tez-tests.txt tez-tests: The patch generated 6 new + 1042 unchanged - 7 fixed = 1048 total (was 1049)
-0 ⚠️ checkstyle 0m 11s /results-checkstyle-tez-ext-service-tests.txt tez-ext-service-tests: The patch generated 1 new + 40 unchanged - 1 fixed = 41 total (was 41)
-0 ⚠️ checkstyle 0m 42s /results-checkstyle-root.txt root: The patch generated 92 new + 5263 unchanged - 93 fixed = 5355 total (was 5356)
+1 💚 javadoc 4m 14s the patch passed
-1 ❌ spotbugs 0m 23s /patch-spotbugs-tez-api.txt tez-api in the patch failed.
-1 ❌ spotbugs 0m 19s /patch-spotbugs-tez-common.txt tez-common in the patch failed.
-1 ❌ spotbugs 0m 23s /patch-spotbugs-tez-runtime-internals.txt tez-runtime-internals in the patch failed.
-1 ❌ spotbugs 0m 22s /patch-spotbugs-tez-runtime-library.txt tez-runtime-library in the patch failed.
-1 ❌ spotbugs 0m 20s /patch-spotbugs-tez-mapreduce.txt tez-mapreduce in the patch failed.
-1 ❌ spotbugs 0m 19s /patch-spotbugs-tez-examples.txt tez-examples in the patch failed.
-1 ❌ spotbugs 0m 23s /patch-spotbugs-tez-dag.txt tez-dag in the patch failed.
-1 ❌ spotbugs 0m 20s /patch-spotbugs-tez-tests.txt tez-tests in the patch failed.
-1 ❌ spotbugs 0m 20s /patch-spotbugs-tez-ext-service-tests.txt tez-ext-service-tests in the patch failed.
-1 ❌ spotbugs 0m 20s /patch-spotbugs-tez-plugins_tez-yarn-timeline-history.txt tez-yarn-timeline-history in the patch failed.
-1 ❌ spotbugs 0m 20s /patch-spotbugs-tez-plugins_tez-yarn-timeline-history-with-acls.txt tez-yarn-timeline-history-with-acls in the patch failed.
-1 ❌ spotbugs 0m 24s /patch-spotbugs-tez-plugins_tez-history-parser.txt tez-history-parser in the patch failed.
-1 ❌ spotbugs 0m 20s /patch-spotbugs-tez-plugins_tez-aux-services.txt tez-aux-services in the patch failed.
-1 ❌ spotbugs 0m 24s /patch-spotbugs-tez-tools_analyzers_job-analyzer.txt job-analyzer in the patch failed.
-1 ❌ spotbugs 0m 15s /patch-spotbugs-root.txt root in the patch failed.
_ Other Tests _
+1 💚 unit 2m 3s tez-api in the patch passed.
+1 💚 unit 0m 29s tez-common in the patch passed.
+1 💚 unit 0m 46s tez-runtime-internals in the patch passed.
+1 💚 unit 4m 13s tez-runtime-library in the patch passed.
+1 💚 unit 1m 3s tez-mapreduce in the patch passed.
+1 💚 unit 0m 20s tez-examples in the patch passed.
+1 💚 unit 5m 40s tez-dag in the patch passed.
+1 💚 unit 34m 46s tez-tests in the patch passed.
+1 💚 unit 3m 42s tez-ext-service-tests in the patch passed.
+1 💚 unit 1m 30s tez-yarn-timeline-history in the patch passed.
+1 💚 unit 1m 37s tez-yarn-timeline-history-with-acls in the patch passed.
+1 💚 unit 2m 4s tez-history-parser in the patch passed.
+1 💚 unit 2m 32s tez-aux-services in the patch passed.
+1 💚 unit 2m 16s job-analyzer in the patch passed.
+1 💚 unit 59m 44s root in the patch passed.
+1 💚 asflicense 3m 48s The patch does not generate ASF License warnings.
194m 8s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/3/artifact/out/Dockerfile
GITHUB PR #450
Optional Tests dupname asflicense javac javadoc unit codespell detsecrets xmllint compile spotbugs checkstyle
uname Linux ee29f201a231 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-450/src/.yetus/personality.sh
git revision master / 8fd1676
Default Java Ubuntu-21.0.9+10-Ubuntu-124.04
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/3/testReport/
Max. process+thread count 1371 (vs. ulimit of 5500)
modules C: tez-api tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-examples tez-dag tez-tests tez-ext-service-tests tez-plugins/tez-yarn-timeline-history tez-plugins/tez-yarn-timeline-history-with-acls tez-plugins/tez-history-parser tez-plugins/tez-aux-services tez-tools/analyzers/job-analyzer . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/3/console
versions git=2.43.0 maven=3.8.7 codespell=2.4.1
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Contributor Author

spotbugs is broken as TEZ-4669, rest looks good to me
it's strange that so few checkstyle warnings have been solved, but I'm still confident this spotless rule made the code better

@abstractdog abstractdog requested a review from ayushtkn January 26, 2026 14:48
@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 5m 24s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 3s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 91 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 2m 20s Maven dependency ordering for branch
+1 💚 mvninstall 7m 13s master passed
+1 💚 compile 6m 26s master passed
+1 💚 checkstyle 5m 3s master passed
+1 💚 javadoc 5m 8s master passed
+0 🆗 spotbugs 1m 31s tez-api in master has 545 extant spotbugs warnings.
+0 🆗 spotbugs 0m 28s tez-common in master has 13 extant spotbugs warnings.
+0 🆗 spotbugs 0m 34s tez-runtime-internals in master has 111 extant spotbugs warnings.
+0 🆗 spotbugs 0m 42s tez-runtime-library in master has 235 extant spotbugs warnings.
+0 🆗 spotbugs 0m 33s tez-mapreduce in master has 124 extant spotbugs warnings.
+0 🆗 spotbugs 0m 26s tez-examples in master has 2 extant spotbugs warnings.
+0 🆗 spotbugs 1m 1s tez-dag in master has 749 extant spotbugs warnings.
+0 🆗 spotbugs 0m 33s tez-tests in master has 6 extant spotbugs warnings.
+0 🆗 spotbugs 0m 32s tez-ext-service-tests in master has 62 extant spotbugs warnings.
+0 🆗 spotbugs 0m 29s tez-plugins/tez-yarn-timeline-history in master has 2 extant spotbugs warnings.
+0 🆗 spotbugs 0m 30s tez-plugins/tez-yarn-timeline-history-with-acls in master has 2 extant spotbugs warnings.
+0 🆗 spotbugs 0m 31s tez-plugins/tez-history-parser in master has 21 extant spotbugs warnings.
+0 🆗 spotbugs 0m 30s tez-plugins/tez-aux-services in master has 5 extant spotbugs warnings.
+0 🆗 spotbugs 4m 2s root in master has 1935 extant spotbugs warnings.
+0 🆗 spotbugs 0m 30s tez-tools/analyzers/job-analyzer in master has 20 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 6m 18s the patch passed
+1 💚 codespell 0m 47s No new issues.
+1 💚 compile 6m 35s the patch passed
+1 💚 javac 6m 35s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 19s /results-checkstyle-tez-api.txt tez-api: The patch generated 1 new + 551 unchanged - 1 fixed = 552 total (was 552)
-0 ⚠️ checkstyle 0m 15s /results-checkstyle-tez-common.txt tez-common: The patch generated 2 new + 66 unchanged - 2 fixed = 68 total (was 68)
-0 ⚠️ checkstyle 0m 21s /results-checkstyle-tez-runtime-library.txt tez-runtime-library: The patch generated 4 new + 688 unchanged - 4 fixed = 692 total (was 692)
-0 ⚠️ checkstyle 0m 20s /results-checkstyle-tez-mapreduce.txt tez-mapreduce: The patch generated 62 new + 687 unchanged - 62 fixed = 749 total (was 749)
-0 ⚠️ checkstyle 0m 26s /results-checkstyle-tez-dag.txt tez-dag: The patch generated 16 new + 1829 unchanged - 16 fixed = 1845 total (was 1845)
-0 ⚠️ checkstyle 0m 20s /results-checkstyle-tez-tests.txt tez-tests: The patch generated 6 new + 1041 unchanged - 7 fixed = 1047 total (was 1048)
-0 ⚠️ checkstyle 0m 14s /results-checkstyle-tez-ext-service-tests.txt tez-ext-service-tests: The patch generated 1 new + 40 unchanged - 1 fixed = 41 total (was 41)
-0 ⚠️ checkstyle 0m 48s /results-checkstyle-root.txt root: The patch generated 92 new + 5257 unchanged - 93 fixed = 5349 total (was 5350)
+1 💚 javadoc 4m 52s the patch passed
+1 💚 spotbugs 14m 13s the patch passed
_ Other Tests _
+1 💚 unit 2m 5s tez-api in the patch passed.
+1 💚 unit 0m 31s tez-common in the patch passed.
+1 💚 unit 0m 48s tez-runtime-internals in the patch passed.
+1 💚 unit 4m 30s tez-runtime-library in the patch passed.
+1 💚 unit 1m 4s tez-mapreduce in the patch passed.
+1 💚 unit 0m 21s tez-examples in the patch passed.
+1 💚 unit 5m 26s tez-dag in the patch passed.
+1 💚 unit 34m 55s tez-tests in the patch passed.
+1 💚 unit 3m 48s tez-ext-service-tests in the patch passed.
+1 💚 unit 1m 33s tez-yarn-timeline-history in the patch passed.
+1 💚 unit 1m 39s tez-yarn-timeline-history-with-acls in the patch passed.
+1 💚 unit 2m 7s tez-history-parser in the patch passed.
+1 💚 unit 2m 36s tez-aux-services in the patch passed.
+1 💚 unit 2m 21s job-analyzer in the patch passed.
+1 💚 unit 60m 10s root in the patch passed.
+1 💚 asflicense 4m 22s The patch does not generate ASF License warnings.
217m 59s
Subsystem Report/Notes
Docker ClientAPI=1.53 ServerAPI=1.53 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/5/artifact/out/Dockerfile
GITHUB PR #450
Optional Tests dupname asflicense javac javadoc unit codespell detsecrets xmllint compile spotbugs checkstyle
uname Linux 98f56b03d2ca 5.15.0-141-generic #151-Ubuntu SMP Sun May 18 21:35:19 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-450/src/.yetus/personality.sh
git revision master / 1d8b852
Default Java Ubuntu-21.0.10+7-Ubuntu-124.04
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/5/testReport/
Max. process+thread count 2105 (vs. ulimit of 5500)
modules C: tez-api tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-examples tez-dag tez-tests tez-ext-service-tests tez-plugins/tez-yarn-timeline-history tez-plugins/tez-yarn-timeline-history-with-acls tez-plugins/tez-history-parser tez-plugins/tez-aux-services tez-tools/analyzers/job-analyzer . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-450/5/console
versions git=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.4.1
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Contributor Author

checkstyle seems to be clean (or at least there is equal or less warnings)
@ayushtkn : could you please review?

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants