feat(sec): resolve all vuln alerts in superset-embedded-sdk, superset-frontend and docs#41776
Open
hainenber wants to merge 6 commits into
Open
feat(sec): resolve all vuln alerts in superset-embedded-sdk, superset-frontend and docs#41776hainenber wants to merge 6 commits into
superset-embedded-sdk, superset-frontend and docs#41776hainenber wants to merge 6 commits into
Conversation
Signed-off-by: hainenber <dotronghai96@gmail.com>
…Webpack loader Signed-off-by: hainenber <dotronghai96@gmail.com>
…ed Webpack config Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Contributor
|
Bito Automatic Review Skipped - Large PR |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41776 +/- ##
=======================================
Coverage 64.70% 64.70%
=======================================
Files 2686 2686
Lines 148626 148626
Branches 34298 34298
=======================================
Hits 96164 96164
Misses 50697 50697
Partials 1765 1765
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(sec): resolve all vuln alerts in
superset-embedded-sdk,superset-frontendanddocsSUMMARY
Aside from fixing ALL vuln alerts at the time of writing for said directories, there are a few notable changes in this PR as well:
webpack.extend.tsin docs into tsconfig.json for type checking and corresponding type fix.INTHEWILDfile to remove usage of unmaintainedjs-yaml-loader.Regarding 2nd item, I've manually checked and there are no discrepancies between
docsbuilt locally and what has been deployedLocally build

docsDeployed

docsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Green CI for acceptance criterion
ADDITIONAL INFORMATION