Skip to content

feat(i18n): backfill Polish (pl) translations (AI-generated, needs review)#41660

Merged
hainenber merged 1 commit into
masterfrom
feat/i18n-pl-translations
Jul 2, 2026
Merged

feat(i18n): backfill Polish (pl) translations (AI-generated, needs review)#41660
hainenber merged 1 commit into
masterfrom
feat/i18n-pl-translations

Conversation

@rusackas

@rusackas rusackas commented Jul 2, 2026

Copy link
Copy Markdown
Member

SUMMARY

Backfills the remaining untranslated entries in the Polish (pl) catalog using scripts/translations/backfill_po.py (Claude, cross-language context), skipping do-not-translate tokens (icon names, enum values, SQL keywords, API field names, placeholders — see #41651).

All generated strings are marked #, fuzzy with an attribution comment. The #, fuzzy flag marks each entry as machine-generated and needing native-speaker review. Note on serving: both the frontend (po2json --fuzzy) and backend (pybabel compile --use-fuzzy, see #41648) builds include fuzzy entries, so these translations render in the UI once built — reviewers should verify each and remove the #, fuzzy flag to confirm. Format placeholders are preserved (verified programmatically).

Tracked by check_translation_regression.py as untranslated → fuzzy, which is explicitly not a regression. Part of a per-language sweep.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Translation catalog only — no layout or behavior change. Strings render once the frontend/backend are rebuilt.

TESTING INSTRUCTIONS

  • pybabel compile --use-fuzzy -d superset/translations -l pl succeeds.
  • Polish native speakers: review the #, fuzzy entries and de-fuzz once confirmed.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
  • Introduces new feature or API
  • Removes existing feature or API

…view)

Fills the remaining untranslated entries in the Polish catalog using
scripts/translations/backfill_po.py (Claude, cross-language context), skipping
do-not-translate tokens. All generated strings are marked `#, fuzzy` with an
attribution comment for native-speaker review; they preserve format
placeholders. Both the frontend (`po2json --fuzzy`) and backend builds serve
fuzzy entries, so reviewers should verify and de-fuzz to confirm.

Catalog re-normalized to the Babel 2.17 canonical format via `pybabel update`.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@rusackas rusackas requested a review from sfirke as a code owner July 2, 2026 02:55
@rusackas rusackas requested a review from kgabryje July 2, 2026 02:55
@dosubot dosubot Bot added the i18n:general Related to translations label Jul 2, 2026
@github-actions github-actions Bot added the i18n Namespace | Anything related to localization label Jul 2, 2026
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.62%. Comparing base (748060d) to head (65aaae1).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #41660      +/-   ##
==========================================
- Coverage   64.63%   64.62%   -0.01%     
==========================================
  Files        2674     2674              
  Lines      147711   147711              
  Branches    34098    34098              
==========================================
- Hits        95466    95459       -7     
- Misses      50509    50513       +4     
- Partials     1736     1739       +3     
Flag Coverage Δ
hive 39.10% <ø> (ø)
mysql 57.83% <ø> (ø)
postgres 57.89% <ø> (-0.01%) ⬇️
presto 40.64% <ø> (ø)
python 59.30% <ø> (-0.01%) ⬇️
sqlite 57.47% <ø> (ø)
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bito-code-review bito-code-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Agent Run #437a94

Actionable Suggestions - 13
Additional Suggestions - 4
  • superset/translations/pl/LC_MESSAGES/messages.po - 4
    • Duplicate msgid entries (punctuation variant) · Line 3110-3121
      The diff introduces two new entries with msgids differing only by a trailing period ("Cannot delete theme ... dark theme" vs "Cannot delete theme ... dark theme."). This is semantic duplication: the meaning is identical and both are marked fuzzy with the same translation. One entry is sufficient. Check the source codebase to determine which variant (with or without period) is actually used, then keep only that one.
    • Wrong translation: Validate expression · Line 18111-18118
      msgstr "Nieprawidłowe wyrażenie CRON" (Invalid CRON expression) is wrong for msgid "Validate your expression" — it fixes only a CRON-specific case while the English msgid is a generic validation action. The backfill_po.py tool likely confused this with a CRON validation error message also present in the file.
    • Inconsistent product name casing · Line 6669-6669
      The translation at line 6669 uses lowercase "matrixify" while the msgid and the earlier "Enable Matrixify" entry (line 6623) both use title-case "Matrixify". Polish is a language where capitalization changes word meaning, and since this feature name is localized (not a built-in UI term), the msgstr should mirror the msgid casing to prevent inconsistent display text across the UI.
    • Wrong translation: Unpin · Line 17766-17767
      The existing msgstr "uruchomiony" for msgid "Unpin" means "running" or "launched" — clearly incorrect. The root verb "unpin" translates to "Odepnij" in Polish, as confirmed by the new sibling entries added in this diff. This pre-existing translation predates the current backfill run.
Filtered by Review Rules

Bito filtered these suggestions based on rules created automatically for your feedback. Manage rules.

Review Details
  • Files reviewed - 1 · Commit Range: 65aaae1..65aaae1
    • superset/translations/pl/LC_MESSAGES/messages.po
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Comment thread superset/translations/pl/LC_MESSAGES/messages.po
Comment thread superset/translations/pl/LC_MESSAGES/messages.po
Comment thread superset/translations/pl/LC_MESSAGES/messages.po
Comment thread superset/translations/pl/LC_MESSAGES/messages.po
Comment thread superset/translations/pl/LC_MESSAGES/messages.po
Comment thread superset/translations/pl/LC_MESSAGES/messages.po
Comment thread superset/translations/pl/LC_MESSAGES/messages.po
Comment thread superset/translations/pl/LC_MESSAGES/messages.po
Comment thread superset/translations/pl/LC_MESSAGES/messages.po
Comment thread superset/translations/pl/LC_MESSAGES/messages.po
Comment thread superset/translations/pl/LC_MESSAGES/messages.po
Comment thread superset/translations/pl/LC_MESSAGES/messages.po
Comment thread superset/translations/pl/LC_MESSAGES/messages.po
@hainenber hainenber merged commit 9769380 into master Jul 2, 2026
63 checks passed
@hainenber hainenber deleted the feat/i18n-pl-translations branch July 2, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n:general Related to translations i18n Namespace | Anything related to localization size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants