SONK-3386: Fix encoding issue (#1)#33956
Closed
isaac-jaynes-imperva wants to merge 1 commit into
Closed
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Incorrect Logic for Schema Modification Condition ▹ view | 🧠 Incorrect |
 |
Schema Path Conversion Logic Not Properly Encapsulated ▹ view | 🧠 Not in scope |
Files scanned
| File Path | Reviewed |
|---|---|
| superset/db_engine_specs/drill.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| ) -> tuple[URL, dict[str, Any]]: | ||
| if schema: | ||
| uri = uri.set(database=parse.quote(schema.replace(".", "/"), safe="")) | ||
| if uri.get_driver_name() == 'sadrill' and uri.get_backend_name() != 'drill': |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Does this break other, non-mongo queries?
Comment on lines
+90
to
+91
| if uri.get_driver_name() == 'sadrill' and uri.get_backend_name() != 'drill': | ||
| schema = schema.replace(".", "/") |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
|
@cgivre I just stumbled across this... any thoughts on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't format mongo commands with a '/' if using drill+sadrill.
Needed in addition to JohnOmernik/sqlalchemy-drill#98 to make MongoDB + SqlAlchemyDrill + Superset to work properly