[SPARK-46166][PS] Implementation of pandas.DataFrame.any with axis=None#53478
Closed
devin-petersohn wants to merge 7 commits into
Closed
[SPARK-46166][PS] Implementation of pandas.DataFrame.any with axis=None#53478devin-petersohn wants to merge 7 commits into
devin-petersohn wants to merge 7 commits into
Conversation
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com> Co-authored-by: Devin Petersohn <devin.petersohn@snowflake.com>
| axis: Optional[Axis] = 0, | ||
| bool_only: Optional[bool] = None, | ||
| skipna: bool = True, | ||
| **kwargs: Any, |
Contributor
There was a problem hiding this comment.
it seems kwargs are not used/passed in the PR, and don't have a test for it
Contributor
Author
There was a problem hiding this comment.
kwargs are only there for numpy compatibility and do not change behavior. From pandas and the docstring in this PR:
**kwargs: Any, default None
Additional keywords have no effect but might be accepted for compatibility with
NumPy.
Do we need a test for it?
Contributor
There was a problem hiding this comment.
I cannot find an example with kwargs in https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.any.html,
not sure how it works in pandas.
But in PS, I prefer not adding it if it doesn't take effect.
Contributor
Author
There was a problem hiding this comment.
SGTM, removed kwargs (it is ignored in pandas).
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
HyukjinKwon
approved these changes
Dec 21, 2025
Member
|
Merged to master. |
|
I opened #56623 to address this. The details are in the PR; happy to adjust based on what you'd prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support for
axis=Noneinpandas.DataFrame.any.Why are the changes needed?
New API
Does this PR introduce any user-facing change?
New parameter support for an existing API.
How was this patch tested?
CI / local
Was this patch authored or co-authored using generative AI tooling?
No