-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Improve][Transform-V2][Embedding]Enhance multimodal embeddings #9996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davidzollo
merged 19 commits into
apache:dev
from
loupipalien:enhance-multimodal-embeddings
Jun 29, 2026
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2c285d6
enhance multimodal embeddings
loupipalien 5af23f6
fix: fix VectorFieldSpecTest test case
loupipalien 7c994be
chore: add spotless toggleOffOn
loupipalien 593fef9
chore: code format
loupipalien 4e9f707
chore:remove deduplicated code
loupipalien 1209fdb
chore: modify comment
loupipalien 85f2dbe
fix: fix set isMultimodalFileds
loupipalien f2703aa
test: upgrade testcontainers for docker test
loupipalien e962868
chore: add log
loupipalien a5da9f2
fix: use reference filter instead of image name filter
loupipalien a31cac3
chore: increase connector-file-local-it job timeout
loupipalien d3fdca9
fix: fix some bugs and add docs
loupipalien ecac9fb
chore: increase all-connectors-it-1 job timeout
loupipalien 10856f4
chore: update docs and remove unnecessary comment
loupipalien 55d9a91
modify: create a new object avoid to share SrcFieldSpec
loupipalien b333d2b
chore: revert testcontainer version and ci timeout minutes
loupipalien d3ca789
chore: revert to image name filter
loupipalien 5724f00
chore: remove spotless toggleOffOn
loupipalien afd0fd7
fix: only detect modality when modality not explicitly configurated a…
loupipalien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isMultimodalFields = vectorFieldSpec.isMultimodalField();
There is a logical issue; currently, only the last value can be obtained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loupipalien
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your time, let me fix it