[Bug][Connector-V2][Postgres-CDC] Handle duplicate replication slot by SQL state#11166
Closed
LeonYoah wants to merge 1 commit into
Closed
[Bug][Connector-V2][Postgres-CDC] Handle duplicate replication slot by SQL state#11166LeonYoah wants to merge 1 commit into
LeonYoah wants to merge 1 commit into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Fixes #10992.
Postgres CDC should not depend on a localized error message to detect an existing replication slot. This PR keeps the SQLState
42710check and moves it into a helper, with the old English message check as a fallback.Basis:
42710asduplicate_objectin PG 13 and current PG.ERRCODE_DUPLICATE_OBJECT: slot.c.Does this PR introduce any user-facing change?
Yes. When the replication slot already exists and PostgreSQL returns a localized message, Postgres CDC logs a warning and continues.
How was this patch tested?
Local reproduction:
sqlState=42710and message错误: 复制槽名 "seatunnel" 已经存在.PostgresSourceFetchTaskContext.INSERT : 4, delta_fix.sqlState=42710for a duplicated replication slot.Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.