[Test][Zeta] Wait for final canceled state in role test#11139
Open
DanielLeens wants to merge 2 commits into
Open
[Test][Zeta] Wait for final canceled state in role test#11139DanielLeens wants to merge 2 commits into
DanielLeens wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a follow-up CI baseline fix split out from #11136.
#11136hit a new unrelated failure inunit-test (8, ubuntu-latest):SeaTunnelEngineClusterRoleTest.testWorkerIsFirstMemberThenGetJobDetailStatusThe failure was not in the Pulsar code path. The test was asserting
jobClient.getJobStatus(jobId)directly aftercancelJob(jobId)during master failover, and CI showed the transient state could remainCANCELINGbefore the final terminal result became visible.This change makes the test wait for
clientJobProxy.waitForJobCompleteV2()first, then asserts the final client-visible status isCANCELED.Why is this needed?
The previous version only increased timeout and polling, but the failing CI still timed out on the transient
CANCELINGstate. Waiting on the finalJobResultmatches the real completion boundary and avoids sampling the intermediate state as a terminal assertion.Validation
Ran:
./mvnw -nsu -pl seatunnel-engine/seatunnel-engine-client spotless:applyAttempted but blocked by unrelated local compile issues already present on the clean
apache/devworktree:./mvnw -nsu -pl seatunnel-engine/seatunnel-engine-client -am -DfailIfNoTests=false -Dtest=SeaTunnelEngineClusterRoleTest#testWorkerIsFirstMemberThenGetJobDetailStatus test./mvnw -nsu -pl seatunnel-engine/seatunnel-engine-client -DfailIfNoTests=false -Dtest=SeaTunnelEngineClusterRoleTest#testWorkerIsFirstMemberThenGetJobDetailStatus testThe local blocker was not this test change itself:
seatunnel-config-shadesources in this machine's worktreeMultipleTableJobConfigParserTesttestCompile errors on the cleanapache/devcheckout before this change could be exercisedseatunnel-engine-uiwas not changed and was not revalidated in this run.