fix(cli): share the TUI wait budget - #4180
Draft
adity982 wants to merge 1 commit into
Draft
Conversation
Generated-by: OpenAI Codex Signed-off-by: Aditya Datta <crazyme07071996@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
tui-mcp-control.test.ts's iteration-count polling loop with the shared TUI wait helper. All 28 call sites now inherit the established local/CI wall-clock budget andMAKA_TEST_WAIT_BUDGET_MSoverride; the observed credential-retirement race also gets a specific timeout description.Fixes #4094
Verification
node --test packages/cli/dist/__tests__/tui-mcp-control.test.js— 19 passednpx biome check packages/cli/src/__tests__/tui-mcp-control.test.ts— passednpm --workspace maka-agent testbuilt all prerequisites and ran the suite, but the Windows host reported unrelated pre-existing permission/durability failures (EPERMfor symlink/fsync) plus unrelated timing assertions. The focused MCP controller file passed independently.AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex traced the existing shared helper, prepared the focused import/removal change, and ran validation. The human contributor of record reviews and owns the submission.
Checklist
Does this PR entail a change in behavior?