Skip to content

fix(cli): share the TUI wait budget - #4180

Draft
adity982 wants to merge 1 commit into
apache:mainfrom
adity982:fix/tui-mcp-wait-budget
Draft

fix(cli): share the TUI wait budget#4180
adity982 wants to merge 1 commit into
apache:mainfrom
adity982:fix/tui-mcp-wait-budget

Conversation

@adity982

Copy link
Copy Markdown

Summary

Replace tui-mcp-control.test.ts's iteration-count polling loop with the shared TUI wait helper. All 28 call sites now inherit the established local/CI wall-clock budget and MAKA_TEST_WAIT_BUDGET_MS override; the observed credential-retirement race also gets a specific timeout description.

Fixes #4094

Verification

  • node --test packages/cli/dist/__tests__/tui-mcp-control.test.js — 19 passed
  • npx biome check packages/cli/src/__tests__/tui-mcp-control.test.ts — passed
  • Full npm --workspace maka-agent test built all prerequisites and ran the suite, but the Windows host reported unrelated pre-existing permission/durability failures (EPERM for symlink/fsync) plus unrelated timing assertions. The focused MCP controller file passed independently.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: OpenAI Codex traced the existing shared helper, prepared the focused import/removal change, and ran validation. The human contributor of record reviews and owns the submission.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

Generated-by: OpenAI Codex
Signed-off-by: Aditya Datta <crazyme07071996@gmail.com>
@github-actions github-actions Bot added the effort/S Under 100 readable lines label Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/S Under 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(cli): tui-mcp-control's local waitFor spins 1000 immediates with no wall-clock budget, flaky under CI load

1 participant