Skip to content

fix(desktop): truncate long file paths in the changes panel #4155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
Aug 29, 2026
+28 −0
Merged

fix(desktop): truncate long file paths in the changes panel #4155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions apps/desktop/src/renderer/styles/workbar/review.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,17 @@
flex: 1;
}

/* Collapsible wraps the trigger row in its own flex <span>, which keeps the
browser default `min-width: auto` and so refuses to shrink below the full
file path — the row overflows the narrow panel and clips the change counts
and chevron instead of truncating the path. Let that label track the trigger
width so the path ellipsizes and the stats stay in view. */
.maka-session-review-file .astryx-collapsible-trigger > span:first-child {
min-width: 0;
flex: 1 1 auto;
overflow: hidden;
}

.maka-session-review-file-path {
min-width: 0;
flex: 1;
Expand Down
17 changes: 17 additions & 0 deletions apps/desktop/stories/session-workbar.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,23 @@ const artifactText: Record<string, string> = {
};

const gitReviewFiles: GitReviewSnapshot['files'] = [
{
// The deep path is deliberate: it is what proves a long file path
// ellipsizes inside the narrow panel instead of pushing the change counts
// and chevron off the row (issue: 变更 rows clipped when the path is long).
path: '.scratch/pyclient/gen/client/Comparator_pb2.py',
status: 'added',
additions: 129,
deletions: 0,
diff: [
'diff --git a/.scratch/pyclient/gen/client/Comparator_pb2.py b/.scratch/pyclient/gen/client/Comparator_pb2.py',
'--- /dev/null',
'+++ b/.scratch/pyclient/gen/client/Comparator_pb2.py',
'@@ -0,0 +1,2 @@',
'+# Generated by the protocol buffer compiler. DO NOT EDIT!',
'+from google.protobuf import descriptor as _descriptor',
].join('\n'),
},
{
path: 'apps/desktop/src/renderer/session-review-panel.tsx',
status: 'modified',
Expand Down