JCRVLT-831: For collection of namespace prefixed, avoid interating over sibling nodes not contained in the filter(s) #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er sibling nodes not contained in the filter(s)
reschke
commented
Dec 17, 2025
| } | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
note to myself: that could include timing information
|
LGTM |
…er sibling nodes not contained in the filter(s) - duration logging
joerghoh
reviewed
Dec 17, 2025
| // respective aggregator building sub aggregates | ||
| while (nIter.hasNext()) { | ||
| Node n = nIter.nextNode(); | ||
| visited += 1; |
Contributor
There was a problem hiding this comment.
Suggested change
| visited += 1; | |
| visited++; |
Contributor
Author
There was a problem hiding this comment.
hmmm... why? I'm a violating a style guide I'm not away of?
Contributor
There was a problem hiding this comment.
nope :-) In my opinion it's just more readable, as with "+=" I always need to parse the number behind it, while "++" is hardwired to "increase a counter" in my brain.
But I am nitpicking here :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the namespace walk; the prefixes are collected during the first (and now only) walk.