ignite-27446 Extended string and literals in union #7297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korlov42
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request contains changes to several files in the project, focusing on improvements, cleanup, and small fixes. The key modifications include simplifying test data, updating comments to reference correct ticket formatting, addressing inconsistencies in queries and projections, and enabling a previously disabled integration test.
Main Changes:
Release Documentation Updates: Adjusted the release guide in RELEASE.md to reflect an updated process sequence and removed obsolete references.
Code Cleanup:
Fixed Jira issue links and formatting in comments (CatalogUtils.java, LimitOffsetPlannerTest.java).
Removed the @disabled annotation in ItDockerConfigTest.java, re-enabling the test.
Test Changes:
Updated query results and test data formatting in multiple integration tests, including cases of trailing whitespaces and benchmark references (test_basic_union.test, test_group_by_distinct.test, test_coalesce.test).
Removed ignored test files related to COALESCE and DECODE SQL functions.
SQL Engine Enhancements:
Standardized character type usage by converting CHAR to VARCHAR in SQL plans across various files for consistency.
Added a new method shouldConvertRaggedUnionTypesToVarying in the IgniteTypeSystem class, likely for handling type coercion in SQL operations.
This PR does not involve large feature additions but focuses on incremental improvements, maintenance, and quality.