feat(integration): implement iggy_harness macro and test utils#2603
Closed
feat(integration): implement iggy_harness macro and test utils#2603
iggy_harness macro and test utils#2603Conversation
hubcio
force-pushed
the
test-binaries-refactor
branch
14 times, most recently
from
6141de1 to
69572b2
Compare
Integration tests duplicated 30+ lines of TestServer/ClientFactory setup per scenario, making maintenance painful and inconsistent cleanup causing occasional test pollution. The harness centralizes binary lifecycle in TestContext which guarantees cleanup regardless of test outcome. Tests now declare infrastructure needs via #[iggy_harness] macro instead of imperative setup. IGGY_* env passthrough lets CI override test defaults without code changes - useful for testing specific configurations. IGGY_TEST_CLEANUP_DISABLED preserves test_logs/ for debugging. Lastly, fixed WebSocket TLS - client factory lacked TLS config propagation, causing handshake failures after harness refactor.
hubcio
force-pushed
the
test-binaries-refactor
branch
from
69572b2 to
a8ded8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests duplicated 30+ lines of TestServer/ClientFactory
setup per scenario, making maintenance painful and inconsistent
cleanup causing occasional test pollution.
The harness centralizes binary lifecycle in TestContext which
guarantees cleanup regardless of test outcome. Tests now declare
infrastructure needs via #[iggy_harness] macro instead of
imperative setup.
IGGY_* env passthrough lets CI override test defaults without
code changes - useful for testing specific configurations.
IGGY_TEST_CLEANUP_DISABLED preserves test_logs/ for debugging.
Lastly, fixed WebSocket TLS - client factory lacked TLS config
propagation, causing handshake failures after harness refactor.
IGGY_CI_BUILD triggered timestamp capture, forcing relinks.
Removed it from pre-merge to enable incremental builds and
cache hits.