refactor(server): replace slab ECS with LeftRight-based global metadata#2555
Merged
refactor(server): replace slab ECS with LeftRight-based global metadata#2555
Conversation
bc75595 to
f7b7bc6
Compare
61eae14 to
c8b6bdc
Compare
5d443ab to
12bf4f9
Compare
ba0e23c to
d971aad
Compare
numinnex
requested changes
Jan 22, 2026
8a1a24c to
2d20028
Compare
Contributor
|
Overall, this looks good. If you don't have anything else to add there (tests or anything), I think we could merge this. |
Contributor
Author
|
@krishvishal @spetz @mmodzelewski mind taking a look? |
Centralizing metadata into a single LeftRight store provides lock-free reads across shards and eliminates coordination complexity inherent in the distributed slab approach. Shards now read from a shared snapshot while shard 0 exclusively handles writes, ensuring consistency without per-read synchronization.
2d20028 to
0e81d8f
Compare
krishvishal
suggested changes
Jan 23, 2026
Contributor
krishvishal
left a comment
There was a problem hiding this comment.
In the add_stream we are currently using 0 as the sentinel value but in add_topic we are using usize:MAX as the sentinel value. This can be inconsistent.
iggy/core/server/src/metadata/writer.rs
Lines 68 to 69 in 0e81d8f
0e81d8f to
6588e1a
Compare
Contributor
Author
good catch, fixed |
spetz
approved these changes
Jan 23, 2026
krishvishal
approved these changes
Jan 23, 2026
numinnex
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralizing metadata into a single LeftRight store provides lock-free
reads across shards and eliminates coordination complexity inherent in
the distributed slab approach. Shards now read from a shared snapshot
while shard 0 exclusively handles writes, ensuring consistency without
per-read synchronization.