Repository navigation
[Improvement-18768][Server] Separate registration from heartbeat RPC queries - #18769
Draft
ruanwenjun wants to merge 11 commits into
Draft
ruanwenjun wants to merge 11 commits into
ruanwenjun wants to merge 11 commits into
Conversation
ruanwenjun
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
November 4, 2026 08:17
ruanwenjun
marked this pull request as draft
November 4, 2026 08:21
Inject RPC fetch functions from Master and API, and name the service-to-service heartbeat data interval heartbeat-fetch-interval.
…apshots Generate Master and Worker heartbeat data on request, retain independent failover checks, schedule Alert registration updates in its registry client, and remove BaseHeartBeatTask.
ruanwenjun
force-pushed
the
Improvement-18768
branch
from
November 6, 2026 06:31
41e8581 to
ff85bd8
Compare
…egistration identity
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES. AI assisted with implementation, tests, documentation, and the PR description; the synchronization topology and behavior were agreed with the contributor.
Purpose of the pull request
Closes #18768.
Master, Worker and Alert Server currently rewrite full heartbeat data in registry nodes, coupling payload size and synchronization frequency to registry writes. Store stable process identity in
ServerIdentityand fetch runtime heartbeats over RPC. Master polls peer Masters and Workers; API queries Master/Worker/Alert heartbeats directly on each request.Brief change log
MasterClustersandWorkerClustersowns one timer thread and synchronously fetches its nodes in sequence, waitingmaster.heartbeat-fetch-interval(default1s) after each round. Remove the additional RPC executors, in-flight sets and Worker expiration fields. Store only the local successful receipt time asheartbeatReceivedTime. ClusterManager only initializes members and wires subscriptions and listeners. Create metadata throughparseFromHeartBeatonly after a valid heartbeat.metadataStale=true, while healthy nodes still return data. Validate each response against the discovered process identity.alert.max-heartbeat-intervaland the obsolete configuration examples.ServerIdentity, including nodes that never returned a heartbeat. Runtime metadata removal does not trigger failover. Apply the Worker weight from its first valid heartbeat to the fixed-weight load balancer.BaseHeartBeatTaskand its Master/Worker/Alert subclasses. UseSelfFailoverMonitorto check whether the current Master/Worker process has been failed over and stop it independently of heartbeat RPC traffic.dolphinscheduler-service.Verify this pull request
./mvnw -o spotless:applyand the Spotless checks in the focused test reactor pass.git diff --checkpasses.python3 img_utils.py -v dev-syntaxandpython3 img_utils.py -v check) pass. All three Issue Mermaid diagrams were rendered and inspected.vue-tsc --noEmitand ESLint for the changed monitoring files pass.Full-suite tests, a complete cluster upgrade/failover exercise, and production performance have not been validated. API query latency now includes node RPCs. CI status is tracked separately.
Pull Request Notice
Pull Request Notice