Repository navigation
Conversation
github-actions
Bot
added
sqllogictest
Contributor
Author
|
Hi @comphead, could you approve the CI run when you have a moment? Thanks! |
abp002
force-pushed
the
spark-pow-strictmath
branch
from
October 24, 2026 20:58
c60cd36 to
81b37da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
datafusion-sparkreturns1forpow(1, NaN)andpow(±1, ±Infinity)where Spark returns NaN, andInfinityforpow(-0.0, -1.0)where Spark returns-Infinity.What changes are included in this PR?
The special case for a zero base is removed, since
powfalready givesInfinityfor0.0and-Infinityfor-0.0with a negative odd exponent. A NaN exponent, or a base of1or-1with an infinite exponent, now returns NaN.What is the testing strategy for this PR?
New and updated cases in
spark/math/pow.slt, for both the scalar and the array path.Are there any user-facing changes?
powandpowerreturn NaN or-Infinityin these cases, as Spark does.