Skip to content

fix: remove duplicate predicate benchmark result - #26244

Open
Omega359 wants to merge 1 commit into
apache:mainfrom
Omega359:fix-predicate-eval-result
Open

Omega359 wants to merge 1 commit into
apache:mainfrom
Omega359:fix-predicate-eval-result

Conversation

@Omega359

@Omega359 Omega359 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

No linked issue.

Rationale for this change

Running benchmark_runner predicate_eval --query 1 --iterations 1 --rows 1000000 fails while parsing the template with multiple results found.

What changes are included in this PR?

Remove the duplicate result directive from predicate_eval.benchmark.template.

What is the testing strategy for this PR?

Using the existing debug benchmark runner, reproduced the parser error with the original template and verified the fixed template completes query 1 successfully with one result row. cargo fmt --all passed.

cargo clippy --all-targets --all-features -- -D warnings fails on three mutable_key_type diagnostics in unchanged datafusion/optimizer/src/push_down_filter.rs on upstream main. The standard ./dev/rust_lint.sh suite passed. Extended workspace tests are still running; they have reached the SQL logic tests after passing the preceding Rust test binaries. Test data is supplied from the existing checkout via ARROW_TEST_DATA and PARQUET_TEST_DATA.

Are there any user-facing changes?

The predicate evaluation benchmark can run again.

@Omega359
Omega359 marked this pull request as ready for review October 12, 2026 17:16

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Omega359 !

I am stoked to see this get close to completion

@alamb
alamb enabled auto-merge October 12, 2026 18:12
@alamb
alamb added this pull request to the merge queue Oct 12, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.82%. Comparing base (6663e43) to head (fe3aa01).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26244      +/-   ##
==========================================
- Coverage   82.83%   82.82%   -0.01%     
==========================================
  Files        1149     1149              
  Lines      452344   452344              
  Branches   452344   452344              
==========================================
- Hits       374680   374672       -8     
- Misses      54864    54872       +8     
  Partials    22800    22800              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants