Repository navigation
Conversation
Omega359
marked this pull request as ready for review
October 12, 2026 17:16
alamb
enabled auto-merge
October 12, 2026 18:12
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26244 +/- ##
==========================================
- Coverage 82.83% 82.82% -0.01%
==========================================
Files 1149 1149
Lines 452344 452344
Branches 452344 452344
==========================================
- Hits 374680 374672 -8
- Misses 54864 54872 +8
Partials 22800 22800 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No linked issue.
Rationale for this change
Running
benchmark_runner predicate_eval --query 1 --iterations 1 --rows 1000000fails while parsing the template withmultiple results found.What changes are included in this PR?
Remove the duplicate
resultdirective frompredicate_eval.benchmark.template.What is the testing strategy for this PR?
Using the existing debug benchmark runner, reproduced the parser error with the original template and verified the fixed template completes query 1 successfully with one result row.
cargo fmt --allpassed.cargo clippy --all-targets --all-features -- -D warningsfails on threemutable_key_typediagnostics in unchangeddatafusion/optimizer/src/push_down_filter.rson upstream main. The standard./dev/rust_lint.shsuite passed. Extended workspace tests are still running; they have reached the SQL logic tests after passing the preceding Rust test binaries. Test data is supplied from the existing checkout viaARROW_TEST_DATAandPARQUET_TEST_DATA.Are there any user-facing changes?
The predicate evaluation benchmark can run again.